Skip to content

✨ Release envtest v1.33.0#1198

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
dongjiang1989:update-envtest-1.33
May 7, 2025
Merged

✨ Release envtest v1.33.0#1198
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
dongjiang1989:update-envtest-1.33

Conversation

@dongjiang1989
Copy link
Member

@dongjiang1989 dongjiang1989 commented Apr 28, 2025

ref: kubernetes-sigs/controller-runtime#3200

Add envtest v1.33.0

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2025
@k8s-ci-robot k8s-ci-robot requested a review from chrischdi April 28, 2025 12:48
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 28, 2025

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from vincepri April 28, 2025 12:48
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2025
@dongjiang1989 dongjiang1989 mentioned this pull request Apr 28, 2025
Closed
@sbueringer
Copy link
Member

sbueringer commented May 7, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2025
@sbueringer
Copy link
Member

sbueringer commented May 7, 2025

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 7, 2025

LGTM label has been added.

DetailsGit tree hash: 1cee27aede3d84ad1592963093fa340995ca4558

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongjiang1989, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2025
@dongjiang1989 @sbueringer
add envtest v1.33.0
dfabafd 
Signed-off-by: dongjiang <dongjiang1989@126.com>
@sbueringer sbueringer force-pushed the update-envtest-1.33 branch from b362ca8 to dfabafd Compare May 7, 2025 11:16
@sbueringer
Copy link
Member

sbueringer commented May 7, 2025

GitHub was stuck in a strange state, I force-pushed the exact same commit again. Looks like that helped

@k8s-ci-robot k8s-ci-robot merged commit bd1faab into kubernetes-sigs:main May 7, 2025
6 checks passed
sbueringer pushed a commit to sbueringer/controller-tools that referenced this pull request May 7, 2025
@k8s-ci-robot
Merge pull request kubernetes-sigs#1198 from dongjiang1989/update-env…
19b9620 
…test-1.33

 ✨ Release envtest v1.33.0
@sbueringer
Copy link
Member

sbueringer commented May 7, 2025

Somehow this PR did not trigger the action that builds & publishes the binaries. On my fork it's working...

@sbueringer sbueringer mentioned this pull request May 7, 2025
Merged
@dongjiang1989 dongjiang1989 deleted the update-envtest-1.33 branch May 7, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dongjiang1989 @k8s-ci-robot @sbueringer