Updated cloudstack go sdk to v2.17.1#449
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome @sureshanaparti! |
|
Hi @sureshanaparti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Setting up environment failed |
3 similar comments
|
Setting up environment failed |
|
Setting up environment failed |
|
Setting up environment failed |
|
/ok-to-test |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CloudStack Go SDK to v2.17.1 and adjusts both production and test code to match the updated API signature. Key changes include:
- Updating the parameter order in NewCreateVPCParams to include the VPC CIDR.
- Reflecting the API changes in both production code (vpc.go) and tests (vpc_test.go).
- Upgrading dependency versions in go.mod, including the cloudstack-go SDK version and several ancillary package updates.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/cloud/vpc_test.go | Update test expectations to match new CreateVPC parameters. |
| pkg/cloud/vpc.go | Update production call for NewCreateVPCParams to include vpc.CIDR. |
| go.mod | Upgrade cloudstack-go and other dependencies to newer versions. |
Comments suppressed due to low confidence (2)
pkg/cloud/vpc.go:108
- The updated API signature now requires the CIDR as the first parameter. Consider adding a brief in-line comment to clarify this change for future maintainers.
p := c.cs.VPC.NewCreateVPCParams(vpc.CIDR, vpc.Name, vpc.Name, offeringID, fd.Spec.Zone.ID)
pkg/cloud/vpc_test.go:169
- Ensure that the test mock accurately reflects the updated API call by passing the CIDR parameter. A comment noting the API change could be useful for context.
vs.EXPECT().NewCreateVPCParams(dummyVPC.CIDR, dummyVPC.Name, dummyVPC.Name, offeringID, dummyFD.Spec.Zone.ID).Return(createVPCParams)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 25.78% 25.77% -0.02%
==========================================
Files 72 72
Lines 6778 6777 -1
==========================================
- Hits 1748 1747 -1
Misses 4865 4865
Partials 165 165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test Results : (tid-877) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sureshanaparti, vishesh92 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
This updates cloudstack go sdk to v2.17.1.
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.