Skip to content

[release-0.3] 🐛 prevent false lint error#147

Closed
k8s-infra-cherrypick-robot wants to merge 1 commit into
kubernetes-sigs:release-0.3from
k8s-infra-cherrypick-robot:cherry-pick-145-to-release-0.3
Closed

[release-0.3] 🐛 prevent false lint error#147
k8s-infra-cherrypick-robot wants to merge 1 commit into
kubernetes-sigs:release-0.3from
k8s-infra-cherrypick-robot:cherry-pick-145-to-release-0.3

Conversation

@k8s-infra-cherrypick-robot

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Jun 8, 2023

Copy link
Copy Markdown

This is an automated cherry-pick of #145

/assign furkatgofurov7

@Fedosin
fix: prevent false lint error
11084c6 
Gosec linter reports a false error `G101: Potential hardcoded credentials (gosec)`.
To prevent it we disable the linter in that place.
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 8, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2023
@k8s-ci-robot

k8s-ci-robot commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furkatgofurov7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2023
@furkatgofurov7

furkatgofurov7 commented Jun 8, 2023

Copy link
Copy Markdown
Member

/hold

DO NOT MERGE! This is for testing kubernetes/test-infra#29726

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2023
@furkatgofurov7 furkatgofurov7 mentioned this pull request Jun 8, 2023
Merged
@furkatgofurov7

furkatgofurov7 commented Jun 8, 2023

Copy link
Copy Markdown
Member

/retest

@furkatgofurov7

furkatgofurov7 commented Jun 8, 2023

Copy link
Copy Markdown
Member

/close

@k8s-ci-robot

k8s-ci-robot commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

@furkatgofurov7: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@furkatgofurov7 furkatgofurov7 Awaiting requested review from furkatgofurov7

Assignees

@furkatgofurov7 furkatgofurov7

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k8s-infra-cherrypick-robot @k8s-ci-robot @furkatgofurov7 @Fedosin