Skip to content

🐛 prevent false lint error#145

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
Fedosin:fix_linting
Jun 7, 2023
Merged

🐛 prevent false lint error#145
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
Fedosin:fix_linting

Conversation

@Fedosin

@Fedosin Fedosin commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Gosec linter reports a false error G101: Potential hardcoded credentials (gosec). To prevent it we disable the linter in that place.

Gosec linter reports a false error `G101: Potential hardcoded credentials (gosec)`.
To prevent it we disable the linter in that place.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2023

@damdo damdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023

@furkatgofurov7 furkatgofurov7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9335374 into kubernetes-sigs:main Jun 7, 2023
@furkatgofurov7

Copy link
Copy Markdown
Member

/cherry-pick release-0.3

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown

@furkatgofurov7: new pull request created: #147

Details

In response to this:

/cherry-pick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants