Skip to content

Merge pull request #27 from sbezverk/issue_26#28

Merged
k8s-ci-robot merged 2 commits into
kubernetes-csi:release-1.0from
sbezverk:release_1.0_26
Dec 20, 2018
Merged

Merge pull request #27 from sbezverk/issue_26#28
k8s-ci-robot merged 2 commits into
kubernetes-csi:release-1.0from
sbezverk:release_1.0_26

Conversation

@sbezverk

Copy link
Copy Markdown
Contributor

Fixing leaking connections

Cherry picked from master

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 20, 2018

@saad-ali saad-ali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2018
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, sbezverk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2018
@sbezverk

Copy link
Copy Markdown
Contributor Author

/lgtm

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@sbezverk: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saad-ali

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit b454847 into kubernetes-csi:release-1.0 Dec 20, 2018
jsafrane pushed a commit to jsafrane/livenessprobe that referenced this pull request Sep 29, 2022
…cy-openshift-4.10-csi-livenessprobe

Updating csi-livenessprobe images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants