Use registry.k8s.io for deployment by AdityaC45 · Pull Request #221 · kubernetes-csi/external-resizer

AdityaC45 · 2022-08-27T08:10:43Z

What type of PR is this?
/kind feature deprecation

What this PR does / why we need it:

Related to:
kubernetes-csi/external-snapshotter#687
Switch to the new endpoint for container images. See: https://github.com/kubernetes/k8s.io/wiki/New-Registry-url-for-Kubernetes-(registry.k8s.io)

Special notes for your reviewer:
registry.k8s.io is currently a redirect to k8s.gcr.io. The change should be transparent to any pulling from k8s.gcr.io.

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2022-08-27T08:10:51Z

Welcome @AdityaC45!

It looks like this is your first PR to kubernetes-csi/external-resizer 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-resizer has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-08-27T08:10:51Z

Hi @AdityaC45. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2022-08-27T08:10:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AdityaC45
Once this PR has been reviewed and has the lgtm label, please assign gnufied for approval by writing /assign @gnufied in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RaunakShah · 2022-08-30T11:07:20Z

      containers:
        - name: csi-resizer
-          image: gcr.io/k8s-staging-sig-storage/csi-resizer:canary
+          image: registry.k8s.io/k8s-staging-sig-storage/csi-resizer:canary


This image doesn't exist in the registry:

% docker pull registry.k8s.io/k8s-staging-sig-storage/csi-resizer:canary Error response from daemon: manifest for registry.k8s.io/k8s-staging-sig-storage/csi-resizer:canary not found: manifest unknown: Failed to fetch "canary" from request "/v2/k8s-staging-sig-storage/csi-resizer/manifests/canary".

So what should be the image name

The latest resizer image exists:

registry.k8s.io/sig-storage/csi-resizer:v1.5.0

How about changing it to that?

Yeah I am not sure we missed something to publish the image to canary on the new registry. I will ask around.

Thanks for your help

hmmm.. looks like canary is not promoted from staging.

So should I use v1.5.1 image name?

AdityaC45 · 2022-09-01T16:01:25Z

/remove-kind deprecation

AdityaC45 · 2022-09-01T16:02:08Z

/release-note-none

k8s-triage-robot · 2022-12-01T13:25:15Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-12-31T14:15:37Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2023-01-30T15:02:26Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2023-01-30T15:02:29Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

6613c398 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae993 Update k8s image repo url 77e47cce Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b0 Fix dep version mismatch 8f839056 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94dd Update go version to 1.20 to match k/k v1.27 e322ce5e Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a5120 test: fix golint error aa61bfd0 Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver 7563d196 Update CSI_PROW_DRIVER_VERSION to v1.11.0 a2171bef Merge pull request kubernetes-csi#216 from msau42/process cb987826 Merge pull request kubernetes-csi#217 from msau42/owners a11216e4 add new reviewers and remove inactive reviewers dd986754 Add step for checking builds b66c0824 Merge pull request kubernetes-csi#214 from pohly/junit-fixes b9b6763b filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit d4277839 filter-junit.go: preserve system error log 38e11468 prow.sh: publish individual JUnit files as separate artifacts git-subtree-dir: release-tools git-subtree-split: 6613c3980d1e418bebb7bc49d64c977cfff85671

Use registry.k8s.io for deployment

e8ee202

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 27, 2022

k8s-ci-robot requested review from humblec and xing-yang August 27, 2022 08:10

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2022

RaunakShah reviewed Aug 30, 2022

View reviewed changes

k8s-ci-robot removed the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Sep 1, 2022

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 1, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 31, 2022

k8s-ci-robot closed this Jan 30, 2023

Conversation

AdityaC45 commented Aug 27, 2022

Uh oh!

k8s-ci-robot commented Aug 27, 2022

Uh oh!

k8s-ci-robot commented Aug 27, 2022

Uh oh!

k8s-ci-robot commented Aug 27, 2022

Uh oh!

RaunakShah Aug 30, 2022

Choose a reason for hiding this comment

Uh oh!

AdityaC45 Aug 31, 2022

Choose a reason for hiding this comment

Uh oh!

RaunakShah Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gnufied Sep 1, 2022

Choose a reason for hiding this comment

Uh oh!

AdityaC45 Sep 1, 2022

Choose a reason for hiding this comment

Uh oh!

humblec Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdityaC45 Sep 2, 2022

Choose a reason for hiding this comment

Uh oh!

AdityaC45 commented Sep 1, 2022

Uh oh!

AdityaC45 commented Sep 1, 2022

Uh oh!

k8s-triage-robot commented Dec 1, 2022

Uh oh!

k8s-triage-robot commented Dec 31, 2022

Uh oh!

k8s-triage-robot commented Jan 30, 2023

Uh oh!

k8s-ci-robot commented Jan 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RaunakShah Sep 1, 2022 •

edited

Loading

humblec Sep 1, 2022 •

edited

Loading