Skip to content

Bump otelgrpc from 0.44.0 to 0.46.0#174

Merged
k8s-ci-robot merged 1 commit into
kubernetes-csi:masterfrom
black-dragon74:bump-otelgrpc
May 29, 2024
Merged

Bump otelgrpc from 0.44.0 to 0.46.0#174
k8s-ci-robot merged 1 commit into
kubernetes-csi:masterfrom
black-dragon74:bump-otelgrpc

Conversation

@black-dragon74

@black-dragon74 black-dragon74 commented May 29, 2024 •
edited by xing-yang
Loading

Copy link
Copy Markdown
Contributor

This fixes CVE-2023-47108

/kind cleanup

What this PR does / why we need it:
cis-lib-utils uses go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.44.0 which is affected by CVE-2023-47108. This patch upgrades the said dependency to 0.46.0, which has the patch for the said vuln.

Does this PR introduce a user-facing change?:

Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.44.0 -> 0.46.0

@black-dragon74
Bump otelgrpc from 0.44.0 to 0.46.0
42e8e54 
This fixes CVE-2023-47108

Signed-off-by: black-dragon74 <niryadav@redhat.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 29, 2024
@k8s-ci-robot

k8s-ci-robot commented May 29, 2024

Copy link
Copy Markdown
Contributor

Welcome @black-dragon74!

It looks like this is your first PR to kubernetes-csi/csi-lib-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-lib-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2024
@k8s-ci-robot

k8s-ci-robot commented May 29, 2024

Copy link
Copy Markdown
Contributor

Hi @black-dragon74. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 29, 2024
@Madhu-1

Madhu-1 commented May 29, 2024

Copy link
Copy Markdown
Contributor

@black-dragon74 can you please add release notes as well?

/assign @jsafrane @xing-yang

@Madhu-1

Madhu-1 commented May 29, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2024
@black-dragon74

black-dragon74 commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

@black-dragon74 can you please add release notes as well?

Sure :)

black-dragon74 added a commit to black-dragon74/kubernetes-csi-addons that referenced this pull request May 29, 2024
@black-dragon74
Manually pin otel-grpc to v0.46.0
123637c 
csi-lib-utils v0.18.0 uses otelgrpc v0.44.0
a pr to update the affected package to v0.46.0 is open
at: kubernetes-csi/csi-lib-utils#174
manually pin the version to v0.46.0, until that pr is merged

Signed-off-by: black-dragon74 <niryadav@redhat.com>
@black-dragon74 black-dragon74 mentioned this pull request May 29, 2024
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 29, 2024
@xing-yang

xing-yang commented May 29, 2024

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2024
@xing-yang

xing-yang commented May 29, 2024

Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot

k8s-ci-robot commented May 29, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
mergify Bot pushed a commit to csi-addons/kubernetes-csi-addons that referenced this pull request May 29, 2024
@black-dragon74 @mergify
Manually pin otel-grpc to v0.46.0
c0e3c47 
csi-lib-utils v0.18.0 uses otelgrpc v0.44.0
a pr to update the affected package to v0.46.0 is open
at: kubernetes-csi/csi-lib-utils#174
manually pin the version to v0.46.0, until that pr is merged

Signed-off-by: black-dragon74 <niryadav@redhat.com>
@k8s-ci-robot k8s-ci-robot merged commit 565ff53 into kubernetes-csi:master May 29, 2024
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/kubernetes-csi-addons that referenced this pull request May 30, 2024
@black-dragon74
Manually pin otel-grpc to v0.46.0
9c05781 
csi-lib-utils v0.18.0 uses otelgrpc v0.44.0
a pr to update the affected package to v0.46.0 is open
at: kubernetes-csi/csi-lib-utils#174
manually pin the version to v0.46.0, until that pr is merged

Signed-off-by: black-dragon74 <niryadav@redhat.com>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/kubernetes-csi-addons that referenced this pull request May 30, 2024
@black-dragon74
Manually pin otel-grpc to v0.46.0
87279a3 
csi-lib-utils v0.18.0 uses otelgrpc v0.44.0
a pr to update the affected package to v0.46.0 is open
at: kubernetes-csi/csi-lib-utils#174
manually pin the version to v0.46.0, until that pr is merged

Signed-off-by: black-dragon74 <niryadav@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauriciopoppe mauriciopoppe Awaiting requested review from mauriciopoppe

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

Assignees

@xing-yang xing-yang

@jsafrane jsafrane

@Madhu-1 Madhu-1

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@black-dragon74 @k8s-ci-robot @Madhu-1 @xing-yang @jsafrane