Skip to content

deploy: fix kustomize issue when using sidecar files for rbac.yaml#302

Merged
k8s-ci-robot merged 1 commit into
kubernetes-csi:masterfrom
pohly:fix-deploy-in-sidecars
May 21, 2021
Merged

deploy: fix kustomize issue when using sidecar files for rbac.yaml#302
k8s-ci-robot merged 1 commit into
kubernetes-csi:masterfrom
pohly:fix-deploy-in-sidecars

Conversation

@pohly

@pohly pohly commented May 21, 2021

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

Using kustomize to add labels to a sidecar's local rbac.yaml file
failed because although the file existed already, referencing it via
an absolute path was rejected by kustomize:

error: accumulating resources: accumulation err='accumulating resources from '/home/prow/go/src/github.com/kubernetes-csi/external-resizer/deploy/kubernetes/rbac.yaml': security; file '/home/prow/go/src/github.com/kubernetes-csi/external-resizer/deploy/kubernetes/rbac.yaml' is not in or below '/tmp/tmp.ehRnbHpnLX'': new root '/home/prow/go/src/github.com/kubernetes-csi/external-resizer/deploy/kubernetes/rbac.yaml' cannot be absolute

Does this PR introduce a user-facing change?:

The deploy scripts did not work when used to test sidecars because kustomize didn't allow rbac.yaml files with absolute paths.

Using kustomize to add labels to a sidecar's local rbac.yaml file
failed because although the file existed already, referencing it via
an absolute path was rejected by kustomize:

error: accumulating resources: accumulation err='accumulating resources from '/home/prow/go/src/github.com/kubernetes-csi/external-resizer/deploy/kubernetes/rbac.yaml': security; file '/home/prow/go/src/github.com/kubernetes-csi/external-resizer/deploy/kubernetes/rbac.yaml' is not in or below '/tmp/tmp.ehRnbHpnLX'': new root '/home/prow/go/src/github.com/kubernetes-csi/external-resizer/deploy/kubernetes/rbac.yaml' cannot be absolute
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 21, 2021
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from xing-yang May 21, 2021 16:04
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2021
@pohly

pohly commented May 21, 2021

Copy link
Copy Markdown
Contributor Author

I have tested the fix locally.

@xing-yang

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit a5f3d62 into kubernetes-csi:master May 21, 2021
k8s-ci-robot pushed a commit that referenced this pull request May 20, 2026
e019f2a7 Merge pull request #302 from jsafrane/bump-go-1.26.2
5966047a Bump go to 1.26.2
058a31d3 Merge pull request #301 from kubernetes-csi/dependabot/github_actions/aquasecurity/trivy-action-0.36.0
50b1a352 Bump aquasecurity/trivy-action from 0.35.0 to 0.36.0
90925279 Merge pull request #298 from torredil/trivy-schedule-trigger
2c9aed3e Merge pull request #299 from andyzhangx/patch-12
507ea1e9 chore: fix broken gcb-docker-gcloud image
ab1da0e9 Run Trivy scan on schedule instead of pull requests
de06a09a Merge pull request #297 from andyzhangx/patch-11
fc719f31 fix: Update Go version from 1.25.8 to 1.25.9
c24a730e Merge pull request #296 from jsafrane/pin-github-actions-sha
59b456b8 fix: pin github action to exact SHA
061f6eed Merge pull request #295 from kubernetes-csi/security/update-trivy-action-v0.35.0
6c16f30b security: Update trivy-action to v0.35.0
119a53c3 Merge pull request #294 from andyzhangx/patch-10
7c9aa9ba fix: upgrade to go1.25.7 to fix CVE-2026-25679

git-subtree-dir: release-tools
git-subtree-split: e019f2a728989ac102400521d9861d6121024c4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants