Skip to content

WIP: Test snapshot controller install#224

Closed
xing-yang wants to merge 1 commit into
kubernetes-csi:masterfrom
xing-yang:test_snapshot_controller_install
Closed

WIP: Test snapshot controller install#224
xing-yang wants to merge 1 commit into
kubernetes-csi:masterfrom
xing-yang:test_snapshot_controller_install

Conversation

@xing-yang

@xing-yang xing-yang commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot

k8s-ci-robot commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

@xing-yang: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 18, 2020
@k8s-ci-robot

k8s-ci-robot commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2020
@k8s-ci-robot

k8s-ci-robot commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

@xing-yang: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-csi-driver-host-path-unit aee2571 link /test pull-kubernetes-csi-csi-driver-host-path-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xing-yang

xing-yang commented Nov 18, 2020

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-alpha-1-19-on-kubernetes-master

@xing-yang xing-yang mentioned this pull request Nov 18, 2020
Merged
@k8s-ci-robot

k8s-ci-robot commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

@xing-yang: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2020
@xing-yang xing-yang closed this Nov 20, 2020
sunnylovestiramisu added a commit to sunnylovestiramisu/csi-driver-host-path that referenced this pull request Apr 26, 2023
@sunnylovestiramisu
Squashed 'release-tools/' changes from 6613c39..4133d1d
591fa77 
4133d1d Merge pull request kubernetes-csi#226 from msau42/cloudbuild
8d519d2 Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest
6e04a03 Merge pull request kubernetes-csi#224 from msau42/cloudbuild
26fdfff Update cloudbuild image

git-subtree-dir: release-tools
git-subtree-split: 4133d1d
TerryHowe pushed a commit to TerryHowe/csi-driver-host-path that referenced this pull request Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#224 from msau42/cloudbuild
6e04a03 
Update cloudbuild image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xing-yang @k8s-ci-robot