Skip to content

Fix replication controller pods delete in tests#1529

Merged
k8s-ci-robot merged 2 commits intokubernetes-client:masterfrom
hedrox:bug-rc-delete
Oct 9, 2021
Merged

Fix replication controller pods delete in tests#1529
k8s-ci-robot merged 2 commits intokubernetes-client:masterfrom
hedrox:bug-rc-delete

Conversation

@hedrox
Copy link
Copy Markdown
Contributor

@hedrox hedrox commented Aug 17, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Tests that create Replication Controller objects don't clean pods upon deletion

Which issue(s) this PR fixes:

Special notes for your reviewer:

This is the follow-up of the issue: kubernetes-client/python-base#242

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 17, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 17, 2021

Welcome @hedrox!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2021
@palnabarun
Copy link
Copy Markdown
Member

palnabarun commented Aug 18, 2021

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 18, 2021
@palnabarun
Copy link
Copy Markdown
Member

palnabarun commented Aug 18, 2021

/remove-label tide/merge-method-squash

Sorry for the noise. 😓

@k8s-ci-robot k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 18, 2021
palnabarun
palnabarun approved these changes Aug 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2021
@palnabarun
Copy link
Copy Markdown
Member

palnabarun commented Aug 18, 2021

/hold for the tests

@roycaihw -- can you please approve the GH Actions for this PR as @hedrox is a first-time contributor?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2021
@hedrox
Copy link
Copy Markdown
Contributor Author

hedrox commented Aug 24, 2021

@palnabarun I think the GH Actions ran and the tests passed.

@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Aug 24, 2021

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hedrox, palnabarun, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 6, 2021
@hedrox
Copy link
Copy Markdown
Contributor Author

hedrox commented Oct 6, 2021

I think the hold label kept the PR from being merged, and now the GH Actions need to be approved again. I will remove the hold after the GH Actions passed. Sorry for the delay.

@hedrox
Copy link
Copy Markdown
Contributor Author

hedrox commented Oct 6, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2021
@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Oct 9, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit be51b01 into kubernetes-client:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@palnabarun palnabarun palnabarun approved these changes

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@palnabarun palnabarun

@yliaog yliaog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hedrox @k8s-ci-robot @palnabarun @yliaog