Skip to content

Add OS X sed check to update-submodule.sh#1456

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
roycaihw:sed-check
May 10, 2021
Merged

Add OS X sed check to update-submodule.sh#1456
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
roycaihw:sed-check

Conversation

@roycaihw
Copy link
Copy Markdown
Member

@roycaihw roycaihw commented May 10, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add the same sed check in update-client.sh to update-submodule.sh, because update-submodule.sh also contains a sed -i command:

sed: 1: "/tmp/python-base-relnot ...": extra characters at the end of p command

Does this PR introduce a user-facing change?

NONE

/cc @Yashks1994 @yliaog

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 10, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 10, 2021

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: Yashks1994.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add the same sed check in update-client.sh to update-submodule.sh, because update-submodule.sh also contains a sed -i command:

sed: 1: "/tmp/python-base-relnot ...": extra characters at the end of p command

Does this PR introduce a user-facing change?

NONE

/cc @Yashks1994 @yliaog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 10, 2021
@k8s-ci-robot k8s-ci-robot requested a review from yliaog May 10, 2021 15:41
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2021
@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented May 10, 2021

better to refactor it out into a util later

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 02c4f7a into kubernetes-client:master May 10, 2021
@roycaihw roycaihw deleted the sed-check branch May 10, 2021 17:07
@roycaihw roycaihw mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roycaihw @k8s-ci-robot @yliaog