Skip to content

Add Python 3.9 to build#1311

Merged
roycaihw merged 1 commit intokubernetes-client:masterfrom
gliptak:python1
Nov 24, 2020
Merged

Add Python 3.9 to build#1311
roycaihw merged 1 commit intokubernetes-client:masterfrom
gliptak:python1

Conversation

@gliptak
Copy link
Copy Markdown
Contributor

@gliptak gliptak commented Nov 10, 2020

Signed-off-by: Gábor Lipták gliptak@gmail.com

@gliptak
Add Python 3.9 to build
213cd83 
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 10, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 10, 2020

Welcome @gliptak!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 10, 2020
@gliptak
Copy link
Copy Markdown
Contributor Author

gliptak commented Nov 11, 2020

/assign @roycaihw

Travis failure seems to be an intermittent unrelated to this PR

roycaihw
roycaihw reviewed Nov 23, 2020
View reviewed changes
@roycaihw
Copy link
Copy Markdown
Member

roycaihw commented Nov 23, 2020

/lgtm
/approve

Test flake fixed in #1329

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gliptak, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@gliptak
Copy link
Copy Markdown
Contributor Author

gliptak commented Nov 23, 2020

@roycaihw kubernetes-client/python-base#217

@roycaihw roycaihw merged commit f461dd4 into kubernetes-client:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roycaihw roycaihw roycaihw left review comments

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gliptak @k8s-ci-robot @roycaihw