Skip to content

Automated Generate from openapi release-1.23#2206

Merged
k8s-ci-robot merged 3 commits intomasterfrom
automated-generate-b6ebe112
Apr 18, 2022
Merged

Automated Generate from openapi release-1.23#2206
k8s-ci-robot merged 3 commits intomasterfrom
automated-generate-b6ebe112

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Apr 8, 2022

No description provided.

Automated openapi generation from release-1.23
f546d12 
Signed-off-by: Kubernetes Prow Robot <k8s.ci.robot@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 8, 2022
@yue9944882
Copy link
Member

yue9944882 commented Apr 8, 2022

@brendandburns interestingly, why the test job not triggered? the generated code in this PR is expected to bring some compile failures i think, and we're supposed to fix the failure by appending commits to this thread

@brendandburns
Copy link
Contributor

brendandburns commented Apr 8, 2022

@yue9944882 is it because it is from the same repo instead of being from an outside repo?

@yue9944882
fixes compile
2598fb5 
Signed-off-by: yue9944882 <291271447@qq.com>
@yue9944882
Copy link
Member

yue9944882 commented Apr 11, 2022

@brendandburns i appended my commit fixing the compile failure on the branch, now the CI jobs are running

@yue9944882
fixes tests
ad2e7e3 
Signed-off-by: yue9944882 <291271447@qq.com>
@brendandburns
Copy link
Contributor

brendandburns commented Apr 18, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, github-actions[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit a295cf3 into master Apr 18, 2022
k8s-ci-robot added a commit that referenced this pull request Apr 18, 2022
@k8s-ci-robot
Merge pull request #2212 from yue9944882/cherrypick-15-regen-openapi
f9f979c 
Cherrypick release-15 #2206: Automated Generate from openapi release-1.23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yue9944882 @brendandburns @k8s-ci-robot