Adding a gh-action for generated java job#2197
Adding a gh-action for generated java job#2197k8s-ci-robot merged 2 commits intokubernetes-client:masterfrom
Conversation
Signed-off-by: yue9944882 <291271447@qq.com>
| with: | ||
| path: gen | ||
| repository: kubernetes-client/gen | ||
| token: ${{ secrets.PAT_TOKEN }} |
There was a problem hiding this comment.
I don't think we need a token do we? This should be fully public.
There was a problem hiding this comment.
the default token doesnt allow any cross-repo read/write even tho the repo is public. so we have to use a PAT token here, i granted the token merely read access
|
Generally looks good. One small comment. We should consider creating a shared robot account so that we don't have to use our own personal access tokens. |
|
Also, fwiw, this won't regenerate the fluent APIs so this is only going to work for patch updates (for now). |
yeah the configured PAT token in this repo is current from my account, but the good news is that the permission is limitted (read only). ideally we should replace my personal token w/ a robot token.
@brendandburns nice catch, now i added fluent generation to the job. |
267693c to
b6459e9
Compare
Signed-off-by: yue9944882 <291271447@qq.com>
b6459e9 to
28fbc77
Compare
|
@brendandburns also we need to pick this to release-15 branch after it's merged |
|
/lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherrypick #2197 to release-15
@brendandburns this automated workflow can help us to do the code generation via manually running workflow, in the end,a PR will be opened. see an example at https://github.com/yue9944882/java/pull/23/files