Skip to content

Gen v1.18.0#385

Merged
k8s-ci-robot merged 5 commits intokubernetes-client:masterfrom
tg123:gen_v1.18.0
Apr 11, 2020
Merged

Gen v1.18.0#385
k8s-ci-robot merged 5 commits intokubernetes-client:masterfrom
tg123:gen_v1.18.0

Conversation

@tg123
Copy link
Member

@tg123 tg123 commented Mar 25, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 25, 2020
@brendandburns
Copy link
Contributor

brendandburns commented Mar 25, 2020

We should really figure out how we want to version things. In the Java client we introduce a new major version for each version of the Kubernetes API. That way people are fore-warned there might be breaking changes.

@tg123
Copy link
Member Author

tg123 commented Mar 25, 2020

agreed
i think we should include k8s version in nuget version.

@brendandburns
Copy link
Contributor

brendandburns commented Apr 1, 2020

@tg123 can you take care of refining the version, then we can merge this.

@tg123
Copy link
Member Author

tg123 commented Apr 1, 2020

@brendandburns for sure, I will send out a proposal about how versioning.

@tg123 tg123 mentioned this pull request Apr 4, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2020
@tg123
Copy link
Member Author

tg123 commented Apr 10, 2020

@brendandburns what do you think if we bump this to v2.0
and bump major version on every code generating

this is the solution 1 in #400 (same as java)

@brendandburns
Copy link
Contributor

brendandburns commented Apr 10, 2020 via email

@tg123
Copy link
Member Author

tg123 commented Apr 11, 2020

bumped to 2.0 and ready to merge

@brendandburns
Copy link
Contributor

brendandburns commented Apr 11, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4ce6e87 into kubernetes-client:master Apr 11, 2020
@aronip aronip mentioned this pull request Aug 24, 2020
Closed
@tg123 tg123 deleted the gen_v1.18.0 branch October 30, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tg123 @brendandburns @k8s-ci-robot