Add myself to approvers#8745
Conversation
I do not have a desire of titles but I am trying this to make the hours I spent on the project worth them. I feel very bad when I have full confidence about a PR and I have reviewed it but I cannot approve it.
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit e1a2e2c https://deploy-preview-8745--kubernetes-io-master-staging.netlify.com |
|
/assign @chenopis @zacharysarah |
|
/lgtm |
|
/lgtm |
|
/LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenopis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I do not have a desire of titles but I am trying this to make the hours I spent on the project worth them. I feel very bad when I have full confidence about a PR and I have reviewed it but I cannot approve it.
|
@tengqm Approver status requires discussion and input from other SIG maintainers. This PR didn't receive adequate discussion, and may be reverted pending further discussion on Slack. Please let me know if you haven't received an invitation to |
|
There's a process for adding maintainers to SIG-Docs that follows the Kubernetes contribution process and guidelines. This PR should not have been merged. I appreciate your enthusiasm, but we have to do this the right way. |
I do not have a desire of titles but I am trying this to make the hours
I spent on the project worth them. I feel very bad when I have full
confidence about a PR and I have reviewed it but I cannot approve it.