Skip to content

Update service.md#7810

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
tanaka-takayoshi:patch-2
Mar 26, 2018
Merged

Update service.md#7810
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
tanaka-takayoshi:patch-2

Conversation

@tanaka-takayoshi
Copy link
Contributor

@tanaka-takayoshi tanaka-takayoshi commented Mar 22, 2018 •
edited
Loading

securityGroupName is the required value when creating LoadBalancer type service in Azure.
I got the following error without securityGroupName value.

Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)

Update service.md
b4e71b6 
`securityGroupName` is the required value when creating LoadBalancer type service in Azure.
I got the following error without `securityGroupName` value.
> Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 22, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 974a3e7

https://deploy-preview-7810--kubernetes-io-master-staging.netlify.com

@tanaka-takayoshi
Copy link
Contributor Author

tanaka-takayoshi commented Mar 22, 2018

/assign heckj

@tengqm
Copy link
Contributor

tengqm commented Mar 22, 2018

/lgtm from writing's perspective, need tech review.

heckj
heckj suggested changes Mar 23, 2018
View reviewed changes
docs/concepts/services-networking/service.md Outdated
**Special notes for Azure**: To use user-specified public type `loadBalancerIP`, a static type
public IP address resource needs to be created first, and it should be in the same resource
group of the cluster. Then you could specify the assigned IP address as `loadBalancerIP`.
group of the cluster. Then you could specify the assigned IP address as `loadBalancerIP`. You
Copy link
Contributor

@heckj heckj Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be updated to show an example of how loadBalancerIP and securityGroupName should be used? The wording as it is highlights that there's things needed, but it's very unclear how to use it or if it's specifically required.

As a suggestion, could you reword this using more imperative, direct english:

Specify the assigned IP address as loadBalancerIP. Verify you have securityGroupName in the cloud provider configuration file.

Or something like that?

@heckj
Copy link
Contributor

heckj commented Mar 23, 2018

/assign

tengqm
tengqm reviewed Mar 26, 2018
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2018
@heckj
Copy link
Contributor

heckj commented Mar 26, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit 770440d into kubernetes:master Mar 26, 2018
chenopis added a commit that referenced this pull request Mar 27, 2018
@chenopis
Merge branch 'master' of https://github.com/kubernetes/website into r…
d97a9cf 
…elease-1.9

* 'master' of https://github.com/kubernetes/website: (549 commits)
  Update service.md (#7810)
  Prune inactive maintainers (#7830)
  add Amadeus to index page and add feature image (#7827)
  Update conventions.md (#7668)
  Adding Tenxcloud as KCSP and Hedvig typo (#7826)
  Update outdated documentation about secret key validation. (#7675)
  Update imperative-command.md (#7699)
  Update manage-deployment.md (#7774)
  Add the OCI runtime description. (#7769)
  fix flag (#7814)
  fix flag (#7813)
  Add files via upload (#7816)
  Remove CoreOS guide that use Kubernetes v0.15.0 (#7821)
  "Nagions" should be "Nagios“ (#7762)
  Update docker-cli-to-kubectl.md (#7748)
  adjust a note format (#7812)
  add a note when mount a configmap to pod (#7745)
  Make using sysctls a task instead of a concept (#6808)
  Partners page updates (#7802)
  Fix a missing word in endpoint reconciler section (#7804)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@bprashanth bprashanth Awaiting requested review from bprashanth

+1 more reviewer

@heckj heckj heckj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@heckj heckj

@tengqm tengqm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tanaka-takayoshi @k8sio-netlify-preview-bot @tengqm @heckj @k8s-ci-robot