Skip to content

Revert #48295 Update KEP-3960 to GA#48657

Merged
k8s-ci-robot merged 1 commit into
kubernetes:dev-1.32from
AxeZhan:revert3960
Nov 7, 2024
Merged

Revert #48295 Update KEP-3960 to GA#48657
k8s-ci-robot merged 1 commit into
kubernetes:dev-1.32from
AxeZhan:revert3960

Conversation

@AxeZhan

@AxeZhan AxeZhan commented Nov 7, 2024

Copy link
Copy Markdown
Member

This reverts commit 563032e.

Description

KEP-3960 will not be able to graduated to GA since lack of Periodic testing, and current tests show bad flaking.

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Nov 7, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 7, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2024
@netlify

netlify Bot commented Nov 7, 2024

Copy link
Copy Markdown

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 036dd68
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/672c15e731c9a40008cccc4d

@netlify

netlify Bot commented Nov 7, 2024

Copy link
Copy Markdown

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 036dd68
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/672c15e702f2290008b55748
😎 Deploy Preview https://deploy-preview-48657--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat

dipesh-rawat commented Nov 7, 2024

Copy link
Copy Markdown
Member

@AxeZhan, Along with this doc revert commit, should we also update the KEP-3960 issue to remove it from the milestone if it’s not set to graduate to stable in this release?

dipesh-rawat
dipesh-rawat reviewed Nov 7, 2024
View reviewed changes

@dipesh-rawat dipesh-rawat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream Revert PR: kubernetes/kubernetes#128627
Status: Merged

/approve

@k8s-ci-robot

k8s-ci-robot commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@AxeZhan

AxeZhan commented Nov 7, 2024

Copy link
Copy Markdown
Member Author

@AxeZhan, Along with this doc revert commit, should we also update the kubernetes/enhancements#3960 issue to remove it from the milestone if it’s not set to graduate to stable in this release?

Yes, thanks for remind.
Are you able to remove it?

@AxeZhan

AxeZhan commented Nov 7, 2024

Copy link
Copy Markdown
Member Author

/cc @thockin @SergeyKanzhelev

@steve-hardman

steve-hardman commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

Looks like the correct thing to restore the old doc when the code has also been reverted.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024
@k8s-ci-robot

k8s-ci-robot commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 4094acc1261e237c7a4d6ffdbd6df18589d827be

@k8s-ci-robot k8s-ci-robot merged commit c64b4e5 into kubernetes:dev-1.32 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@windsonsea windsonsea Awaiting requested review from windsonsea

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@thockin thockin Awaiting requested review from thockin

Assignees

@steve-hardman steve-hardman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

1.32

Development

Successfully merging this pull request may close these issues.

4 participants

@AxeZhan @dipesh-rawat @k8s-ci-robot @steve-hardman