Revert "Graduate PodLifecycleSleepAction to GA"#128627
Merged
Merged
Conversation
Contributor
Author
|
/release-note-none |
Contributor
Author
|
/kind feature |
Contributor
Author
|
/priority important-soon |
Contributor
Author
|
unrelated test issue. /test pull-kubernetes-unit |
Member
|
/lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 72f51bb22a7c1ecac133b185153aace8f5469873 |
Member
|
Sorry, @AxeZhan :( /approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, liggitt, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest |
This was referenced Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #128046
#128613 (comment)
We found that this feature does not have any periodics verifying that the feature is working as intended in the CI.
We should have a periodic that runs this suite before we promote this feature to stable.
Remember, Adding a e2e test will not guarantee it runs in our CI. You have to include that feature. It seems that there is a presubmit for this feature but we are missing a periodic.