Skip to content

Promote RetryGenerateName to GA in 1.32#47770

Merged
k8s-ci-robot merged 4 commits into
kubernetes:dev-1.32from
jpbetz:retry-generate-name-ga
Oct 7, 2024
Merged

Promote RetryGenerateName to GA in 1.32#47770
k8s-ci-robot merged 4 commits into
kubernetes:dev-1.32from
jpbetz:retry-generate-name-ga

Conversation

@jpbetz

@jpbetz jpbetz commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

Description

Promote the RetryGenerateName feature to GA

/sig api-machinery

/hold
until kubernetes/kubernetes#127093 merges

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 3, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2024
@jpbetz jpbetz changed the base branch from main to dev-1.32 September 3, 2024 14:56
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2024
@jpbetz jpbetz mentioned this pull request Sep 3, 2024
Closed
12 tasks
@netlify

netlify Bot commented Sep 3, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 31aba2f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66f4b48bf70602000846362c
😎 Deploy Preview https://deploy-preview-47770--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Sep 3, 2024
View reviewed changes

@sftim sftim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have name generation very briefly mentioned in https://kubernetes.io/docs/concepts/overview/working-with-objects/names/, along with the fact that the API server tries more than once to generate a name but may give up eventually.

@reylejano

reylejano commented Sep 3, 2024

Copy link
Copy Markdown
Member

/milestone 1.32

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Sep 3, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2024
@netlify

netlify Bot commented Sep 23, 2024 •
edited
Loading

Copy link
Copy Markdown

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 31aba2f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66f4b48bbf47f200084f2b2c

@jpbetz

jpbetz commented Sep 23, 2024

Copy link
Copy Markdown
Contributor Author

I'd like to have name generation very briefly mentioned in https://kubernetes.io/docs/concepts/overview/working-with-objects/names/, along with the fact that the API server tries more than once to generate a name but may give up eventually.

I've added a paragraph to the page. PTAL

tengqm
tengqm reviewed Sep 23, 2024
View reviewed changes
Comment thread content/en/docs/concepts/overview/working-with-objects/names.md Outdated
Comment thread content/en/docs/reference/command-line-tools-reference/feature-gates/retry-generate-name.md
jpbetz and others added 2 commits September 26, 2024 01:08
@jpbetz

jpbetz commented Sep 26, 2024

Copy link
Copy Markdown
Contributor Author

All the kubernetes/kubernetes and kubernetes/enhnacements changes for this promotion have merged. This can merge when ready.

@tengqm

tengqm commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@k8s-ci-robot

k8s-ci-robot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@jpbetz

jpbetz commented Oct 1, 2024

Copy link
Copy Markdown
Contributor Author

This just needs LGTM to merge. The implementation is merged.

@sftim Would you be willing to LGTM?

@jpbetz

jpbetz commented Oct 7, 2024

Copy link
Copy Markdown
Contributor Author

Friendly nudge that this is ready to merge

@tengqm

tengqm commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot

k8s-ci-robot commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 2fb42e6b5ee07c1235459d3193fe804c2b592d64

@k8s-ci-robot k8s-ci-robot merged commit e132a42 into kubernetes:dev-1.32 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@reylejano reylejano Awaiting requested review from reylejano

+1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tengqm tengqm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

1.32

Development

Successfully merging this pull request may close these issues.

5 participants

@jpbetz @reylejano @tengqm @k8s-ci-robot @sftim