Skip to content

Fix left panel navigating bar layout issue for zh#19517

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
gavinfish:navigation
Mar 26, 2020
Merged

Fix left panel navigating bar layout issue for zh#19517
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
gavinfish:navigation

Conversation

@gavinfish
Copy link
Copy Markdown
Contributor

Remove comments in _index.md file to fix left panel navigating bar layout issue. I think this fix is ok for two reasons:

  • The content in _index.md is simple and stable.
  • Other languages also organize the _index.md files like this.

fix #18737

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 6, 2020
@gavinfish
Copy link
Copy Markdown
Contributor Author

/assign @SataQiu

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 6, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ab29ea5

https://deploy-preview-19517--kubernetes-io-master-staging.netlify.com

Copy link
Copy Markdown
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gavinfish
/lgtm
/assign @tengqm @markthink

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2020
@markthink
Copy link
Copy Markdown

@gavinfish 英文注释不需要移除的

@gavinfish
Copy link
Copy Markdown
Contributor Author

@gavinfish 英文注释不需要移除的

Hugo 在处理_index.md的时候由于有注释的存在误以为该页面不为空,导致左边导航栏多了额外的子项。

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Mar 26, 2020

Makes perfect sense to me.
/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit a4243ba into kubernetes:master Mar 26, 2020
@gavinfish gavinfish deleted the navigation branch March 26, 2020 05:38
fancc pushed a commit to fancc/website that referenced this pull request Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Left panel navigating bar layout and link bugs

5 participants