Skip to content

Fix the typo#18732

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ZhukovAlexander:patch-1
Jan 16, 2020
Merged

Fix the typo#18732
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ZhukovAlexander:patch-1

Conversation

@ZhukovAlexander
Copy link
Copy Markdown
Contributor

@ZhukovAlexander ZhukovAlexander commented Jan 16, 2020

"AND of exact match" in the "Affinity and anti-affinity" section should be "AND or exact match"

@ZhukovAlexander
Fix the typo
218be7b 
"AND of exact match" in the "Affinity and anti-affinity" section should be "AND or exact match"
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 16, 2020
sftim
sftim reviewed Jan 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small fix
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit f5bfa04 into kubernetes:master Jan 16, 2020
@gedimitr
Copy link
Copy Markdown
Contributor

gedimitr commented Jan 17, 2020

@ZhukovAlexander @sftim I am not so sure that the original text was a typo... the nodeSelector field holds a map of key-value pairs, e.g.:

nodeSelector:
  key1: value1
  key2: value2

For the nodeSelector to fire, label with name key1 must exist and contain value1 exactly AND label with name key2 must exist and contain value2 exactly ==> AND of exact matches

I believe that 'AND or exact match' makes it less clear... What do you think?

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 18, 2020

@gedimitr I think you might be right. Thanks for pointing that out.

@sftim sftim mentioned this pull request Jan 18, 2020
Merged
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@ZhukovAlexander @wawa0210
Fix the typo (kubernetes#18732)
df7d554 
"AND of exact match" in the "Affinity and anti-affinity" section should be "AND or exact match"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidopp davidopp Awaiting requested review from davidopp

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sftim sftim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZhukovAlexander @k8s-ci-robot @gedimitr @sftim