Skip to content

Bump nvidia-device-plugin.yml to 1.0.0-beta4#18725

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
drigz:patch-1
Jan 16, 2020
Merged

Bump nvidia-device-plugin.yml to 1.0.0-beta4#18725
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
drigz:patch-1

Conversation

@drigz
Copy link
Copy Markdown
Contributor

@drigz drigz commented Jan 16, 2020

This resolves no matches for kind "DaemonSet" in version "extensions/v1beta1" with Kubernetes >=1.16.

@drigz
Bump nvidia-device-plugin.yml to 1.0.0-beta4
ff4dcaa 
This resolves `no matches for kind "DaemonSet" in version "extensions/v1beta1"` with Kubernetes >=1.16.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 16, 2020

Welcome @drigz!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 16, 2020
@drigz
Copy link
Copy Markdown
Contributor Author

drigz commented Jan 16, 2020

/assign @simplytunde

sftim
sftim reviewed Jan 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a simple bump
/lgtm
/apply

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2020
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 16, 2020

Oops, I meant
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8aba9c6 into kubernetes:master Jan 16, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@drigz @wawa0210
Bump nvidia-device-plugin.yml to 1.0.0-beta4 (kubernetes#18725)
2087f94 
This resolves `no matches for kind "DaemonSet" in version "extensions/v1beta1"` with Kubernetes >=1.16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradtopol bradtopol Awaiting requested review from bradtopol

@vishh vishh Awaiting requested review from vishh

1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@simplytunde simplytunde

@sftim sftim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drigz @k8s-ci-robot @sftim @simplytunde