Skip to content

remove seeAlso#18722

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
LinshanYu:removesa1
Jan 18, 2020
Merged

remove seeAlso#18722
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
LinshanYu:removesa1

Conversation

@LinshanYu
Copy link
Copy Markdown
Contributor

@LinshanYu LinshanYu commented Jan 16, 2020

REMOVE SEE ALSO section under content/zh/docs/reference/setup-tools/kubeadm/generated.

The 11~15 files.
see the issue #18411

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 16, 2020

Welcome @LinshanYu!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 16, 2020
@tanjunchen
Copy link
Copy Markdown
Contributor

tanjunchen commented Jan 16, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2020
ydcool
ydcool reviewed Jan 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ydcool ydcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tanjunchen
Copy link
Copy Markdown
Contributor

tanjunchen commented Jan 17, 2020

/cc @chenrui333

SataQiu
SataQiu reviewed Jan 18, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @LinshanYu
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit d886fea into kubernetes:master Jan 18, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@LinshanYu @wawa0210
remove seeAlso (kubernetes#18722)
377f048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SataQiu SataQiu SataQiu left review comments

@tengqm tengqm Awaiting requested review from tengqm

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

@chenrui333 chenrui333 Awaiting requested review from chenrui333

+1 more reviewer

@ydcool ydcool ydcool left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tanjunchen tanjunchen

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LinshanYu @k8s-ci-robot @tanjunchen @ydcool @SataQiu