Skip to content

Install legacy iptables binaries for Ubuntu/Debian#18625

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
0xC45:patch-1
Jan 18, 2020
Merged

Install legacy iptables binaries for Ubuntu/Debian#18625
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
0xC45:patch-1

Conversation

@0xC45
Copy link
Copy Markdown
Contributor

@0xC45 0xC45 commented Jan 11, 2020

On the latest Debian 10, the arptables-legacy and ebtables-legacy binaries are not installed by default. Although the (non-legacy) versions are installed by default, it appears the respective packages that provide the legacy binaries must be installed in order to switch to the legacy alternatives. If you attempt to switch to the legacy alternatives without installing the arptables and ebtables packages, you will see an error:

update-alternatives: error: alternative /usr/sbin/arptables-legacy for arptables not registered; not setting

I have confirmed that the packages are present on Debian 10 and Ubuntu 19.10 and they provide the legacy alternatives. See:

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 11, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @0xC45!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 11, 2020
@0xC45
Copy link
Copy Markdown
Contributor Author

0xC45 commented Jan 11, 2020

I have now signed the CLA. Hopefully @k8s-ci-robot will now recognize me and fix the label...

@0xC45
Copy link
Copy Markdown
Contributor Author

0xC45 commented Jan 11, 2020

/assign @jaredbhatti because the bot told me to

@0xC45
Copy link
Copy Markdown
Contributor Author

0xC45 commented Jan 11, 2020

/honk

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@0xC45:
goose image

Details

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Copy Markdown
Member

/check-cla

@neolit123
Copy link
Copy Markdown
Member

@0xC45
thanks for the PR, make sure the email you signed the CLA with is added to your github account.
also that the commit is authored by the same github account.

if this does not work please contact the CNCF help desk.

# ensure legacy binaries are installed
sudo apt-get install -y iptables arptables ebtables

# switch to legacy versions
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change seems good to me.
let me know when you have the CLA resolved.

On the latest Debian 10, the `arptables-legacy` and `ebtables-legacy` binaries are not installed by default. Although the (non-legacy) versions are installed by default, it appears the respective packages that provide the legacy binaries must be installed in order to switch to the legacy alternatives. If you attempt to switch to the legacy alternatives without installing the `arptables` and `ebtables` packages, you will see an error:
```
update-alternatives: error: alternative /usr/sbin/arptables-legacy for arptables not registered; not setting
```

I have confirmed that the packages are present on Debian 10 and Ubuntu 19.10 and they provide the legacy alternatives. See:
* https://packages.ubuntu.com/eoan/amd64/iptables/filelist
* https://packages.ubuntu.com/eoan/amd64/arptables/filelist
* https://packages.ubuntu.com/eoan/amd64/ebtables/filelist
* https://packages.debian.org/buster/amd64/iptables/filelist
* https://packages.debian.org/buster/amd64/arptables/filelist
* https://packages.debian.org/buster/amd64/ebtables/filelist
@0xC45
Copy link
Copy Markdown
Contributor Author

0xC45 commented Jan 12, 2020

/check-cla 🤞

@0xC45
Copy link
Copy Markdown
Contributor Author

0xC45 commented Jan 12, 2020

/check-cla bit of a headache, this process 🙃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 12, 2020
@0xC45
Copy link
Copy Markdown
Contributor Author

0xC45 commented Jan 12, 2020

@neolit123 I am finally a legally-approved contributor. Thanks for the review, please let me know if there's anything else to change.

@neolit123
Copy link
Copy Markdown
Member

/lgtm
/assign @jaredbhatti

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2020
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 18, 2020

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jan 18, 2020
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0xC45
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit b57509b into kubernetes:master Jan 18, 2020
@steadysupply
Copy link
Copy Markdown
Contributor

The legacy binaries are not available in Ubuntu Bionic 18.04 LTS, eg. https://packages.ubuntu.com/bionic/amd64/iptables/filelist

wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
On the latest Debian 10, the `arptables-legacy` and `ebtables-legacy` binaries are not installed by default. Although the (non-legacy) versions are installed by default, it appears the respective packages that provide the legacy binaries must be installed in order to switch to the legacy alternatives. If you attempt to switch to the legacy alternatives without installing the `arptables` and `ebtables` packages, you will see an error:
```
update-alternatives: error: alternative /usr/sbin/arptables-legacy for arptables not registered; not setting
```

I have confirmed that the packages are present on Debian 10 and Ubuntu 19.10 and they provide the legacy alternatives. See:
* https://packages.ubuntu.com/eoan/amd64/iptables/filelist
* https://packages.ubuntu.com/eoan/amd64/arptables/filelist
* https://packages.ubuntu.com/eoan/amd64/ebtables/filelist
* https://packages.debian.org/buster/amd64/iptables/filelist
* https://packages.debian.org/buster/amd64/arptables/filelist
* https://packages.debian.org/buster/amd64/ebtables/filelist
@stefanlasiewski
Copy link
Copy Markdown
Contributor

@steadysupply Did you find a solution to this problem for Ubuntu 18.04, since Ubuntu doesn't provide alternatives like /usr/sbin/iptables-legacy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants