Skip to content

Fix the link for conjure-up#18529

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
makocchi-git:20200108/fix_conjure_up_link
Jan 17, 2020
Merged

Fix the link for conjure-up#18529
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
makocchi-git:20200108/fix_conjure_up_link

Conversation

@makocchi-git
Copy link
Copy Markdown
Contributor

fix #18322

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 8, 2020
@makocchi-git
Copy link
Copy Markdown
Contributor Author

/assign @kbhawkey

### Supported Production Grade Tools

* [conjure-up](/docs/getting-started-guides/ubuntu/) is an open-source installer for Kubernetes that creates Kubernetes clusters with native AWS integrations on Ubuntu.
* [conjure-up](https://conjure-up.io/) is an open-source installer for Kubernetes that creates Kubernetes clusters with native AWS integrations on Ubuntu.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makocchi-git , the change seems fine. This is a link to a third party tool (Canonical).
What do you think about linking directly to the Kubernetes/AWS integration setup page instead of the main page of conjure-up?
https://docs.conjure-up.io/stable/en/cni/k8s-and-aws

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbhawkey Thank you for your comments.
I thought that this deep link has a little bit risky for the location changing by Canonical.
This is the reason why I linked the top-level page.
However, as you mentioned, docs.confure-up.io/.. page is more useful for readers than the top-level page.

So I will change the link to docs.confure-up.io/....

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2020
@makocchi-git
Copy link
Copy Markdown
Contributor Author

ping @kubernetes/sig-docs-en-owners

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 17, 2020

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 50c24e3 into kubernetes:master Jan 17, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
* fix the link for conjure-up

* Fix the link for conjure-up to docs.conjure-up.io
@makocchi-git makocchi-git deleted the 20200108/fix_conjure_up_link branch June 18, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/setup/production-environment/turnkey/aws/

4 participants