Skip to content

Remove outdated Japanese/Chinese notes in favor of default#18490

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
saschagrunert:notes-fallback
Jan 19, 2020
Merged

Remove outdated Japanese/Chinese notes in favor of default#18490
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
saschagrunert:notes-fallback

Conversation

@saschagrunert
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert commented Jan 6, 2020 •
edited
Loading

The notes for the other languages seem outdated and we should stick to the default (en) version.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2020
@saschagrunert saschagrunert changed the title Remove outdated Japanese/Chinese notes in favor of default WIP: Remove outdated Japanese/Chinese notes in favor of default Jan 6, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 6, 2020
@saschagrunert saschagrunert changed the title WIP: Remove outdated Japanese/Chinese notes in favor of default Remove outdated Japanese/Chinese notes in favor of default Jan 6, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2020
@inductor
Copy link
Copy Markdown
Member

inductor commented Jan 8, 2020

Thanks! Japanese one looks good!(so should be Chinese one, too)
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 8, 2020
@inductor
Copy link
Copy Markdown
Member

inductor commented Jan 8, 2020 •
edited
Loading

@saschagrunert
Sorry, I have favour about this.
https://github.com/kubernetes/website/blob/master/content/ja/docs/setup/release/building-from-source.md this page contains the link for release note for the Japanese directory. Can you also change it too?

I had a look at Chinese too but on the master branch there was no reference yet!

@saschagrunert
Remove outdated Japanese/Chinese notes in favor of default
1b0eed7 
The notes for the other languages seem outdated and we should stick to
the default version.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Copy Markdown
Member Author

saschagrunert commented Jan 8, 2020

@saschagrunert
Sorry, I have favour about this.
https://github.com/kubernetes/website/blob/master/content/ja/docs/setup/release/building-from-source.md this page contains the link for release note for the Japanese directory. Can you also change it too?

I had a look at Chinese too but on the master branch there was no reference yet!

Yes sure, I changed the link to match just /docs/setup/release/notes/. 👍

@inductor
Copy link
Copy Markdown
Member

inductor commented Jan 8, 2020

Thanks!

/lgtm

@kubernetes/sig-docs-zh-reviews ping

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2020
@xichengliudui
Copy link
Copy Markdown
Contributor

xichengliudui commented Jan 9, 2020

/lgtm
/approve
from Chinese

@xichengliudui
Copy link
Copy Markdown
Contributor

xichengliudui commented Jan 9, 2020

/lgtm cancel
/approve cancel
The Chinese team will create issue based on the English source file to update, all issues in Chinese do not need to be deleted, if Japanese needs to be deleted, please create a separate pr.
ref：https://github.com/k8smeetup/website-tasks/issues

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2020
@idealhack
Copy link
Copy Markdown
Contributor

idealhack commented Jan 9, 2020

@xichengliudui Since this PR is making changes to the master branch (v1.17 / v1.18) while the Chinese one is for v1.16, I'm inclined to merge it. Then the translation task will be created anyway, right?

@xichengliudui
Copy link
Copy Markdown
Contributor

xichengliudui commented Jan 10, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@inductor
Copy link
Copy Markdown
Member

inductor commented Jan 10, 2020

/assign @kbarnard10

@saschagrunert
Copy link
Copy Markdown
Member Author

saschagrunert commented Jan 10, 2020

Okay thank you for the notice, I now assume that this PR is fine, right?

@inductor
Copy link
Copy Markdown
Member

inductor commented Jan 16, 2020

@kbarnard10 ping

@sftim or can you help? :P

@jimangel
Copy link
Copy Markdown
Member

jimangel commented Jan 19, 2020

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel, xichengliudui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit ad1e9be into kubernetes:master Jan 19, 2020
@saschagrunert saschagrunert deleted the notes-fallback branch January 19, 2020 07:51
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@saschagrunert @wawa0210
Remove outdated Japanese/Chinese notes in favor of default (kubernete…
f476fa9 
…s#18490)

The notes for the other languages seem outdated and we should stick to
the default version.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@MasayaAoyama MasayaAoyama Awaiting requested review from MasayaAoyama

Assignees

@jimangel jimangel

@kbarnard10 kbarnard10

@inductor inductor

@xichengliudui xichengliudui

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@saschagrunert @inductor @xichengliudui @idealhack @jimangel @k8s-ci-robot @kbarnard10