Use Control Plane instead of Master#18438
Conversation
|
/assign @sftim |
sftim
left a comment
There was a problem hiding this comment.
Nice, I'm glad you're tackling this.
I do have a concern that I think should block approval:
This change also needs to update the diagram to say “Control plane” rather than “Master”. I think that if the diagram does not match the text a reader new to Kubernetes might find it frustrating to have to work out the equivalence.
Also, much less important: I think the very first sentence in the page body could read better.
…o re-create it from scratch. I kept the visual similarities as mush as possible
51afc1d to
b4b7821
Compare
|
@sftim As for the other comments, they should all be addressed, I belive |
sftim
left a comment
There was a problem hiding this comment.
minor, but I think important, detail:
Check the glossary definitions for kube-scheduler and kube-controller-manager - these are rendered into that page.
|
@sftim the glossaries should be fixed as well now! |
|
I should have mentioned the glossary definition for A Kubernetes cluster consists of a control plane together with a set of worker
machines, called nodes, that run containerized applications. Every cluster needs at
least one node.
The worker node(s) host the pods that are the components of the application.
The control plane manages the worker nodes and the pods in that cluster. In production
environments, it's typical to run a control plane across multiple computers and also to
run multiple nodes, to provide fault-tolerance and high availability.What do you think? |
|
/lgtm |
|
I'd like more eyes on this because it's a change in wording that will drive further revisions to the site. Happy to approve on lazy consensus. |
celestehorgan
left a comment
There was a problem hiding this comment.
Hello!
These are mostly grammar changes – on the whole this is a great PR! 👍
|
thanks a lot @celestehorgan for the suggested changes :-) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@celestehorgan: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sftim I don't have an official collaborator role on this project yet, so it's not needed – but it does lgtm :) |
|
@celestehorgan that's fine; I'm happy to confirm: |
* Use Control Plane instead of Master * improve image. The SVG was not matching the PNG, so I basically had to re-create it from scratch. I kept the visual similarities as mush as possible * remove tautological phrase * fix glossary references as well * improve cluster glossary to move from Master to Control Plane * improve english form
Control Plane is more specific than Master