Skip to content

Add Alibaba Cloud cloud-controller-manager#18255

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ialidzhikov:enh/add-alicloud-ccm
Jan 16, 2020
Merged

Add Alibaba Cloud cloud-controller-manager#18255
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ialidzhikov:enh/add-alicloud-ccm

Conversation

@ialidzhikov
Copy link
Copy Markdown
Contributor

Add Alibaba Cloud cloud-controller-manager.

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 23, 2019
@k8s-ci-robot k8s-ci-robot requested review from sftim and tengqm December 23, 2019 15:40
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 23, 2019
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2019
@ialidzhikov
Copy link
Copy Markdown
Contributor Author

/assign @ryanmcginnis

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 2, 2020

/sig cloud-provider

PR LGTM; needs approval

@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Jan 2, 2020
@zhangxiaoyu-zidif
Copy link
Copy Markdown
Contributor

zhangxiaoyu-zidif commented Jan 3, 2020

/approve
I can represent the alibaba cloud. cc @tengqm

@kbhawkey
Copy link
Copy Markdown
Contributor

@kbhawkey
Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey, zhangxiaoyu-zidif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 66372da into kubernetes:master Jan 16, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov deleted the enh/add-alicloud-ccm branch May 19, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants