Skip to content

Minor fix.#18182

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sharjeelaziz:p3-topology-manager
Dec 23, 2019
Merged

Minor fix.#18182
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sharjeelaziz:p3-topology-manager

Conversation

@sharjeelaziz
Copy link
Copy Markdown
Contributor

@sharjeelaziz sharjeelaziz commented Dec 17, 2019

Minor fix.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 17, 2019
@sharjeelaziz
Copy link
Copy Markdown
Contributor Author

sharjeelaziz commented Dec 17, 2019

/assign @daminisaty

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 17, 2019

@sharjeelaziz: GitHub didn't allow me to assign the following users: daminisaty.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @daminisaty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Dec 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2019
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Dec 20, 2019

Page preview:
https://deploy-preview-18182--kubernetes-io-master-staging.netlify.com/docs/tasks/administer-cluster/topology-manager/

kbhawkey
kbhawkey reviewed Dec 20, 2019
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2019
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Dec 20, 2019

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2019
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Dec 23, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit bc549fd into kubernetes:master Dec 23, 2019
@sharjeelaziz sharjeelaziz deleted the p3-topology-manager branch December 26, 2019 18:36
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@sharjeelaziz @wawa0210
Minor fix for a typo. (kubernetes#18182)
0472042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@tengqm tengqm Awaiting requested review from tengqm

1 more reviewer

@kbhawkey kbhawkey kbhawkey left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kbhawkey kbhawkey

@tengqm tengqm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sharjeelaziz @k8s-ci-robot @tengqm @kbhawkey