Skip to content

BlockVolume is no longer in alpha#18167

Merged
k8s-ci-robot merged 4 commits intokubernetes:masterfrom
dulltz:update-local-volume
Dec 23, 2019
Merged

BlockVolume is no longer in alpha#18167
k8s-ci-robot merged 4 commits intokubernetes:masterfrom
dulltz:update-local-volume

Conversation

@dulltz
Copy link
Copy Markdown
Contributor

@dulltz dulltz commented Dec 16, 2019

Remove the "alpha" word from BlockVolume since this feature gate is already in beta.

@dulltz
BlockVolume is no longer alpha
e63733b 
Signed-off-by: dulltz <isrgnoe@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 16, 2019

Welcome @dulltz!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 16, 2019
@dulltz dulltz changed the title BlockVolume is no longer alpha BlockVolume is no longer in alpha Dec 16, 2019
sftim
sftim reviewed Dec 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
msau42
msau42 reviewed Dec 16, 2019
View reviewed changes
content/en/docs/concepts/storage/volumes.md Outdated
capacity:
storage: 100Gi
# volumeMode field requires BlockVolume Alpha feature gate to be enabled.
# volumeMode field requires BlockVolume feature gate to be enabled.
Copy link
Copy Markdown
Member

@msau42 msau42 Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably remove it altogether since it's been enabled by default for a while.

@dulltz
Apply comment
fcb2365 
kubernetes#18167 (comment)

Co-Authored-By: Tim Bannister <tim@scalefactory.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@dulltz dulltz requested review from msau42 and sftim December 17, 2019 04:55
sftim
sftim reviewed Dec 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Dec 20, 2019

Page preview:
https://deploy-preview-18167--kubernetes-io-master-staging.netlify.com/docs/concepts/storage/volumes/

kbhawkey
kbhawkey reviewed Dec 20, 2019
View reviewed changes
content/en/docs/concepts/storage/volumes.md
correct node.

PersistentVolume `volumeMode` can be set to "Block" (instead of the default
PersistentVolume `volumeMode` can be set to "Block" (instead of the default
Copy link
Copy Markdown
Contributor

@kbhawkey kbhawkey Dec 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dulltz , What do you think about removing the sentence (end of line 682-683),
The volumeMode field requires BlockVolume feature gate to be enabled.

Copy link
Copy Markdown
Contributor Author

@dulltz dulltz Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbhawkey I agree with it!

@dulltz
Apply comment
ba7237c 
kubernetes#18167 (review)
Signed-off-by: dulltz <isrgnoe@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2019
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Dec 23, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2019
@msau42
Copy link
Copy Markdown
Member

msau42 commented Dec 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 296695d into kubernetes:master Dec 23, 2019
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@dulltz @wawa0210
BlockVolume is no longer in alpha (kubernetes#18167)
e4fec96 
* BlockVolume is no longer alpha

Signed-off-by: dulltz <isrgnoe@gmail.com>

* Apply comment

kubernetes#18167 (comment)

Co-Authored-By: Tim Bannister <tim@scalefactory.com>

* Apply comment

kubernetes#18167 (comment)

* Apply comment

kubernetes#18167 (review)
Signed-off-by: dulltz <isrgnoe@gmail.com>

Co-authored-by: Tim Bannister <tim@scalefactory.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@msau42 msau42 Awaiting requested review from msau42

2 more reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sftim sftim

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dulltz @k8s-ci-robot @kbhawkey @msau42 @sftim