[DOCS-DE] rewrite setup index page#17966
Conversation
|
Welcome @eumel8! |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit a2ba065 https://deploy-preview-17966--kubernetes-io-master-staging.netlify.com |
|
|
||
| Überlegen Sie sich bei der Bewertung einer Lösung für eine Produktionsumgebung, welche Aspekte des Betriebs eines Kubernetes-Clusters (oder von _abstractions_) Sie selbst verwalten oder an einen Anbieter auslagern möchten. | ||
|
|
||
| Einige mögliche Abstraktionen von Kubernetes-Clustern sind {{< glossary_tooltip text="applications" term_id="applications" >}}, {{< glossary_tooltip text="data plane" term_id="data-plane" >}}, {{< glossary_tooltip text="control plane" term_id="control-plane" >}}, {{< glossary_tooltip text="cluster infrastructure" term_id="cluster-infrastructure" >}} und {{< glossary_tooltip text="cluster operations" term_id="cluster-operations" >}}. |
There was a problem hiding this comment.
The tooltip display text is not translated here. Is that intentional?
There was a problem hiding this comment.
related to the svg description in English, so the user can easier find the connections
|
|
||
| Die folgende Tabelle für Produktionsumgebungs-Lösungen listet Anbieter und deren Lösungen auf. | ||
|
|
||
| |Providers | Managed | Turnkey cloud | On-Prem Datacenter | Custom (cloud) | Custom (On-premises VMs)| Custom (Bare Metal) | |
There was a problem hiding this comment.
These headings are not translated. Is that intentional?
There was a problem hiding this comment.
I left it as it is (tooltip display text and table headings). If you look at the test output [1] this text corresponds with the content in the image. We can build our own SVG in German but I think thats not easy to maintain in the future.
[1] https://deploy-preview-17966--kubernetes-io-master-staging.netlify.com/de/docs/setup/
There was a problem hiding this comment.
Ah OK. It would be better to localize that image; ideally, there would be tooling to make that easy (right now, there is not).
There was a problem hiding this comment.
I investigated it a little bit. It's possible to extend the SVG in multi-language style
<switch>
<text
systemLanguage="de"
german text
</text>
<text
systemLanguage="en"
english text
</text>
</switch>
But that would be a very big file in multi-lang and length and size must be adjusted for each text string. Another way would be to use a markdown table instead SVG. Otherwise in Japanese and Korean are already used the origin, maybe it's also a way for German :)
There was a problem hiding this comment.
Hi @sftim,
I want to circle back to this PR. After one month it seems I had no time to work on this SVG stuff. The technical solution should be clear, but I'm not sure if this is common between all language teams. My little hope would be to merge this PR at it is (it's also my first one) and work on the SVG topic later. What do you think?
There was a problem hiding this comment.
That's fine. I hope the German-language localization team agree.
It is usually quite trick to localize images; it's an ideal and in my view it is fine to merge PRs that leave images not yet localized.
There was a problem hiding this comment.
I am ok with keeping the SVG in English. @rlenferink @remyleone what do you think?
There was a problem hiding this comment.
I would say let's keep them in English as it is easier to maintain. But the German localization team is the one that will have the final say imho
There was a problem hiding this comment.
I'd say keep the SVG in English because (as Remy said) it's indeed easier to maintain.
|
How about the actual content change of this PR @bene2k1 ? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bene2k1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* [DOCS-DE] rewrite setup index page * fix table caption * fix whitespace
fixes #17865