kubeadm: remove some CNI plugins from the kubeadm setup guide by neolit123 · Pull Request #17694 · kubernetes/website

neolit123 · 2019-11-20T19:02:56Z

The kubeadm survey for 1.13:
https://docs.google.com/forms/d/1A855D054FZfdvNbx6mAa54tcZ204GmPCIhxe1UrXKd8/edit#responses

Revealed the top 3 plugins in terms of popularity are:

Flannel
Calico
WeaveNet

The kubeadm maintainers are in contact with the maintainers
of these plugins and can provide support and updates to this guide.

The rest of the plugins in the guide are unmaintained, by the kubeadm team!

Some plugins are not in the CNCF landscape, or maintained by the kubeadm team, but still
present in the guide.

Remove the following non-CNCF / unmaintained plugins:

AWS VPC
Romana
Juniper*
Canal (it is an alternative to Calico and already explained in the
Calico guide)

Add note that users can still defer to this page for more details on Pod networking:
https://kubernetes.io/docs/concepts/cluster-administration/networking/
(the removed plugins are present there in a bigger list)

/sig cluster-lifecycle
/kind cleanup

the PR also includes some pod -> Pod renames.

xref kubernetes/enhancements#1326

neolit123 · 2019-11-20T19:10:44Z

@kubernetes/sig-cluster-lifecycle-pr-reviews
/cc @sftim
/assign @zacharysarah

preview: https://deploy-preview-17694--kubernetes-io-master-staging.netlify.com/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/#pod-network

/hold
i'm proposing that we should merge this on lazy consensus until the end of the week.

netlify · 2019-11-20T19:11:40Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 984c12a

https://deploy-preview-17694--kubernetes-io-master-staging.netlify.com

netlify · 2019-11-20T19:13:25Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e5d3f4e

https://deploy-preview-17694--kubernetes-io-master-staging.netlify.com

yagonobre

/lgtm

sftim

I'm happy with this.

How about adding a “find about other CNI plugins” link to the #whats-next section?

content/en/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md

zacharysarah · 2019-11-20T22:19:48Z

@neolit123 I love this idea! I'd also love to get your feedback on the KEP for removing third-party content, given that this PR is highly relevant to that discussion.

neolit123 · 2019-11-20T22:24:31Z

@sftim update:

removed the "choose one..." tab.
added the lnk to the networking section under "what's next"
did some small side cleanup of "pod" -> "Pod"

neolit123 · 2019-11-20T22:25:16Z

@zacharysarah

@neolit123 I love this idea! I'd also love to get your feedback on the KEP for removing third-party content, given that this PR is highly relevant to that discussion.

i think i already had comments on the KEP. will have another pass but overall i think it's in a good shape.

content/en/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md

sftim · 2020-01-15T09:39:17Z

@neolit123 I can see that it's been a while since you opened this
Would you be willing to update it incorporating upstream changes?

neolit123 · 2020-01-15T22:28:18Z

@zacharysarah @sftim
i have rebased the PR on master.

/hold cancel

content/en/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md

The kubeadm survey for 1.13: https://docs.google.com/forms/d/1A855D054FZfdvNbx6mAa54tcZ204GmPCIhxe1UrXKd8/edit#responses The kubeadm survey for 1.13: https://docs.google.com/forms/d/1A855D054FZfdvNbx6mAa54tcZ204GmPCIhxe1UrXKd8/edit#responses Revealed the top 3 plugins in terms of popularity are: Flannel Calico WeaveNet The kubeadm maintainers are in contact with the maintainers of these plugins and can provide support and updates to this guide. The rest of the plugins in the guide are unmaintained, by the kubeadm team! Some plugins are not in the CNCF landscape, or maintained by the kubeadm team, but still present in the guide. Remove the following non-CNCF / unmaintained plugins: AWS VPC Romana Juniper* Canal (it is an alternative to Calico and already explained in the Calico guide) Add note that users can still defer to this page for more options and a more complete list: https://kubernetes.io/docs/concepts/cluster-administration/networking/Revealed the top 3 plugins in terms of popularity are: - Flannel - Calico - WeaveNet The kubeadm maintainers are in contact with the maintainers of these plugins and can provide support and updates to this guide. Some plugins are not in the CNCF landscape, but still covered in this page: https://kubernetes.io/docs/concepts/cluster-administration/networking/ Remove the following non-CNCF plugins: - AWS VPC - Romana - Juniper* - Canal (it is an alternative to Calico and already explained in the Calico guide) Add note that users can still defer to this page for more options: https://kubernetes.io/docs/concepts/cluster-administration/networking/

neolit123 · 2020-01-16T23:54:44Z

@sftim updated.

sftim · 2020-01-17T11:43:40Z

/lgtm
based on #17694 (review) + my judgement

and
/approve

k8s-ci-robot · 2020-01-17T11:45:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…etes#17694) The kubeadm survey for 1.13: https://docs.google.com/forms/d/1A855D054FZfdvNbx6mAa54tcZ204GmPCIhxe1UrXKd8/edit#responses The kubeadm survey for 1.13: https://docs.google.com/forms/d/1A855D054FZfdvNbx6mAa54tcZ204GmPCIhxe1UrXKd8/edit#responses Revealed the top 3 plugins in terms of popularity are: Flannel Calico WeaveNet The kubeadm maintainers are in contact with the maintainers of these plugins and can provide support and updates to this guide. The rest of the plugins in the guide are unmaintained, by the kubeadm team! Some plugins are not in the CNCF landscape, or maintained by the kubeadm team, but still present in the guide. Remove the following non-CNCF / unmaintained plugins: AWS VPC Romana Juniper* Canal (it is an alternative to Calico and already explained in the Calico guide) Add note that users can still defer to this page for more options and a more complete list: https://kubernetes.io/docs/concepts/cluster-administration/networking/Revealed the top 3 plugins in terms of popularity are: - Flannel - Calico - WeaveNet The kubeadm maintainers are in contact with the maintainers of these plugins and can provide support and updates to this guide. Some plugins are not in the CNCF landscape, but still covered in this page: https://kubernetes.io/docs/concepts/cluster-administration/networking/ Remove the following non-CNCF plugins: - AWS VPC - Romana - Juniper* - Canal (it is an alternative to Calico and already explained in the Calico guide) Add note that users can still defer to this page for more options: https://kubernetes.io/docs/concepts/cluster-administration/networking/

k8s-ci-robot requested review from Rajakavitha1 and sftim November 20, 2019 19:03

neolit123 force-pushed the 1.17-prune-cni branch from 984c12a to 4d5d0ed Compare November 20, 2019 19:08

k8s-ci-robot assigned zacharysarah Nov 20, 2019

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2019

neolit123 force-pushed the 1.17-prune-cni branch from 4d5d0ed to f6fa5c3 Compare November 20, 2019 19:15

yagonobre reviewed Nov 20, 2019

View reviewed changes

k8s-ci-robot assigned yagonobre Nov 20, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2019

sftim approved these changes Nov 20, 2019

View reviewed changes

neolit123 force-pushed the 1.17-prune-cni branch from f6fa5c3 to 56eabbb Compare November 20, 2019 22:17

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2019

neolit123 force-pushed the 1.17-prune-cni branch from 56eabbb to bcaf4e7 Compare November 20, 2019 22:23

salv-orlando mentioned this pull request Nov 25, 2019

Add Antrea as a CNI option in create-cluster-kubeadm #17634

Closed

Rajakavitha1 mentioned this pull request Dec 2, 2019

add kube-ovn installation #17904

Closed

detiber reviewed Dec 2, 2019

View reviewed changes

content/en/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md Outdated Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2020

neolit123 force-pushed the 1.17-prune-cni branch from e5d3f4e to 6cbcf20 Compare January 15, 2020 22:25

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2020

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2020

sftim reviewed Jan 16, 2020

View reviewed changes

content/en/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md Outdated Show resolved Hide resolved

neolit123 force-pushed the 1.17-prune-cni branch from 6cbcf20 to 2da659e Compare January 16, 2020 23:54

k8s-ci-robot assigned sftim Jan 17, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020

k8s-ci-robot merged commit 8de8d17 into kubernetes:master Jan 17, 2020

Conversation

neolit123 commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neolit123 commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Nov 20, 2019

Uh oh!

netlify bot commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yagonobre left a comment

Choose a reason for hiding this comment

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zacharysarah commented Nov 20, 2019

Uh oh!

neolit123 commented Nov 20, 2019

Uh oh!

neolit123 commented Nov 20, 2019

Uh oh!

Uh oh!

sftim commented Jan 15, 2020

Uh oh!

neolit123 commented Jan 15, 2020

Uh oh!

Uh oh!

neolit123 commented Jan 16, 2020

Uh oh!

sftim commented Jan 17, 2020

Uh oh!

k8s-ci-robot commented Jan 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

neolit123 commented Nov 20, 2019 •

edited

Loading

neolit123 commented Nov 20, 2019 •

edited

Loading

netlify bot commented Nov 20, 2019 •

edited

Loading