Skip to content

Stop mentioning LegacyNodeRoleBehavior for ServiceNodeExclusion labels#17542

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
yamt:ServiceNodeExclusion
Jan 18, 2020
Merged

Stop mentioning LegacyNodeRoleBehavior for ServiceNodeExclusion labels#17542
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
yamt:ServiceNodeExclusion

Conversation

@yamt
Copy link
Copy Markdown
Contributor

@yamt yamt commented Nov 12, 2019

The text gives me an impression that LegacyNodeRoleBehavior somehow
affects which label is in effect. But actually it doesn't.

@yamt
Stop mentioning LegacyNodeRoleBehavior for ServiceNodeExclusion labels
646ae78 
The text gives me an impression that LegacyNodeRoleBehavior somehow
affects which label is in effect. But actually it doesn't.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 12, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 12, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 646ae78

https://deploy-preview-17542--kubernetes-io-master-staging.netlify.com

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Nov 29, 2019

Is this also a bug in Kubernetes itself? I wonder if the docs are only right until the code is fixed to have the intended behavior?

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 18, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jan 18, 2020
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 18, 2020

I looked at https://github.com/kubernetes/kubernetes/blob/ace98e13820c267cbc4b3ddd8bebdc9a2fda7e4f/pkg/controller/service/controller.go and this PR seems to match what I saw.

sftim
sftim reviewed Jan 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9bfc5d8 into kubernetes:master Jan 18, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@yamt @wawa0210
Stop mentioning LegacyNodeRoleBehavior for ServiceNodeExclusion labels (
9b1dfe4 
kubernetes#17542)

The text gives me an impression that LegacyNodeRoleBehavior somehow
affects which label is in effect. But actually it doesn't.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sftim sftim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yamt @sftim @k8s-ci-robot