Document new stable labels for zone, region and instance-type#17496
Document new stable labels for zone, region and instance-type#17496andrewsykim wants to merge 1 commit intokubernetes:masterfrom andrewsykim:ga-topology-labels
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| if you want to target certain workloads to certain instance types, but typically you want | ||
| to rely on the Kubernetes scheduler to perform resource-based scheduling. You should aim to schedule based on properties rather than on instance types (for example: require a GPU, instead of requiring a `g2.2xlarge`). | ||
|
|
||
| **NOTE**: this label is deprecated, use [node.kubernetes.io/instance-type](nodekubernetesioinstance-type) instead. |
There was a problem hiding this comment.
probably worth noting what release this is deprecated/available in
|
|
||
| See [failure-domain.beta.kubernetes.io/zone](#failure-domainbetakubernetesiozone). | ||
|
|
||
| **NOTE**: this label is deprecated, use [topology.kubernetes.io/region](topologykubernetesioregion) instead. |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 1dd5ac5 https://deploy-preview-17496--kubernetes-io-master-staging.netlify.com |
…de.kubernetes.io/instance-type labels to docs Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
|
Hi @andrewsykim, This looks like docs for enhancement for release v1.17. if it is would you mind opening it against |
|
Should I close this one or keep both open? |
| if you want to target certain workloads to certain instance types, but typically you want | ||
| to rely on the Kubernetes scheduler to perform resource-based scheduling. You should aim to schedule based on properties rather than on instance types (for example: require a GPU, instead of requiring a `g2.2xlarge`). | ||
|
|
||
| **NOTE**: starting in v1.17, this label is deprecated in favor of [node.kubernetes.io/instance-type](nodekubernetesioinstance-type). |
There was a problem hiding this comment.
I recommend using a {{< note >}} shortcode here, and again below.
I would not put a deprecation warning in about a future release (see avoid statements about the future). It's OK to PR targeting v1.17 and say that the label is deprecated since v1.17, or just that it's deprecated.
|
My feeling is that we can close this in favor of #17498. |
|
Thanks /close |
|
@andrewsykim: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Andrew Sy Kim kiman@vmware.com
Enhancement: kubernetes/enhancements#837
PRs: kubernetes/kubernetes#81431 kubernetes/kubernetes#82049
I didn't update examples/setup references to use the new labels because the old beta labels are still the source of truth for v1.17. Those will be updated for v1.18.