Skip to content

Promote Node Zone/Region Topology Labels to GA#81431

Merged
k8s-ci-robot merged 5 commits intokubernetes:masterfrom
andrewsykim:ga-node-topology
Nov 8, 2019
Merged

Promote Node Zone/Region Topology Labels to GA#81431
k8s-ci-robot merged 5 commits intokubernetes:masterfrom
andrewsykim:ga-node-topology

Conversation

@andrewsykim
Copy link
Copy Markdown
Member

@andrewsykim andrewsykim commented Aug 14, 2019 •
edited
Loading

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Updates the following labels:

failure-domain.beta.kubernetes.io/zone -> topology.kubernetes.io/zone
failure-domain.beta.kubernetes.io/region -> topology.kubernetes.io/region

These are widely used labels and although there's a bit of work involved in renaming them, we should update the label names to reflect general availability of these labels. This PR updates settings of the zone/region labels to apply both the beta and GA labels. We will be supporting both labels for the next few releases and eventually phase out the use of beta labels entirely in favor of the GA ones.

Concretely this PR:

  • adds the new GA labels
  • update node controller to apply both GA and beta labels for new and existing nodes (out-of-tree node registration)
  • update kubelet to apply both GA and beta labels for new and existing (in-tree node registration)
  • updates scheduler to read both labels when determining zone predicates (but only the first label found is used)

Which issue(s) this PR fixes:
KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/20190215-promoting-cloud-provider-labels.md

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Deprecate the beta labels for zones ("failure-domain.beta.kubernetes.io/zone") and 
regions ("failure-domain.beta.kubernetes.io/region") in favor of their GA equivalents:
"topology.kubernetes.io/zone" and "topology.kubernetes.io/region". 

The beta labels "failure-domain.beta.kubernetes.io/zone" and "failure-domain.beta.kubernetes.io/region" will be removed in v1.21

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/cloudprovider area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Aug 14, 2019
@andrewsykim andrewsykim mentioned this pull request Aug 27, 2019
Open
@andrewsykim andrewsykim force-pushed the ga-node-topology branch 2 times, most recently from 4919796 to 437ce94 Compare August 27, 2019 16:08
@andrewsykim
Copy link
Copy Markdown
Member Author

andrewsykim commented Aug 27, 2019

/assign @thockin @msau42 @bsalamat

@andrewsykim
node controller: set both deprecated Beta and GA labels for Zone/Regi…
3032c81 
…on topology

Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
@andrewsykim
Copy link
Copy Markdown
Member Author

andrewsykim commented Nov 8, 2019

Reverted commits to remove changes in volume plugins, will squash them once we're happy with the overall changes

liggitt
liggitt reviewed Nov 8, 2019
View reviewed changes
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 8, 2019

/approve

squash for final lgtm.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewsykim
kubelet: set both deprecated Beta and GA labels for zone/region topol…
4c194d5 
…ogy from the cloud provider

Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
@andrewsykim
pkg/util/node: update GetZoneKey to check both beta and GA labels
07229d6 
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
@andrewsykim
test/e2e: check both beta and zone label for getting cluster zone
3497496 
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
@andrewsykim
Copy link
Copy Markdown
Member Author

andrewsykim commented Nov 8, 2019 •
edited
Loading

Revert commits squashed

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 8, 2019

/lgtm

This was referenced Nov 8, 2019
Closed
Merged
@liggitt liggitt mentioned this pull request Nov 8, 2019
Closed
@johscheuer johscheuer mentioned this pull request Nov 20, 2019
Merged
@feiskyer feiskyer mentioned this pull request Dec 25, 2019
Merged
@andrewsykim andrewsykim mentioned this pull request Jan 31, 2020
Closed
@andrewsykim andrewsykim mentioned this pull request Feb 24, 2020
Closed
@notpad notpad mentioned this pull request Mar 23, 2020
Merged
@gavinfish gavinfish mentioned this pull request Apr 9, 2020
Closed
@M00nF1sh M00nF1sh mentioned this pull request May 26, 2020
Merged
@msau42 msau42 mentioned this pull request Jun 17, 2020
Closed
@andrewsykim andrewsykim mentioned this pull request Sep 1, 2020
Merged
@andrewsykim andrewsykim mentioned this pull request Oct 30, 2020
Merged
@msau42 msau42 mentioned this pull request Nov 3, 2020
Merged
@Jiawei0227 Jiawei0227 mentioned this pull request Jan 6, 2021
Closed
@Jiawei0227 Jiawei0227 mentioned this pull request Jan 21, 2021
Closed
@leakingtapan leakingtapan mentioned this pull request Feb 16, 2021
Closed
@baba230896 baba230896 mentioned this pull request Jun 11, 2021
Merged
@froblesmartin froblesmartin mentioned this pull request Apr 8, 2022
Merged
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Mar 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@thockin thockin thockin left review comments

@abrarshivani abrarshivani Awaiting requested review from abrarshivani

@brendandburns brendandburns Awaiting requested review from brendandburns

+5 more reviewers

@bertinatto bertinatto bertinatto left review comments

@caesarxuchao caesarxuchao caesarxuchao left review comments

@davidz627 davidz627 davidz627 left review comments

@yastij yastij yastij left review comments

@msau42 msau42 msau42 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cheftako cheftako

@liggitt liggitt

@thockin thockin

@yastij yastij

@bsalamat bsalamat

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.