Graduate Node-specific Volume Limits to GA by bertinatto · Pull Request #17432 · kubernetes/website

bertinatto · 2019-11-05T11:29:14Z

Graduate Node-specific Volume Limits to GA

xref: kubernetes/enhancements#554

k8sio-netlify-preview-bot · 2019-11-05T11:29:19Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 1d204b4

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dd64ad41c84ac00086eaf6a

bertinatto · 2019-11-05T11:30:15Z

/assign @msau42 @gnufied

makoscafee · 2019-11-05T18:45:27Z

/milestone 1.17

sftim

Informal feedback; I hope it's useful.

sftim · 2019-11-06T19:00:26Z

content/en/docs/concepts/storage/storage-limits.md


-Kubernetes 1.11 introduced support for dynamic volume limits based on Node type as an Alpha feature.
-In Kubernetes 1.12 this feature is graduating to Beta and will be enabled by default.
+Support for dynamic volume limits was introduced as an Alpha feature in Kubernetes 1.11.


Now that the feature is stable, it's (IMO) OK to omit the history. Readers can look at the v1.16 docs (one before the version it went GA) if they are interested.

Re-worded, PTAL

content/en/docs/concepts/storage/storage-limits.md

msau42 · 2019-11-13T17:53:16Z

/lgtm

msau42 · 2019-11-13T17:53:34Z

Oh actually, can you update feature-gates.md too?
/lgtm cancel

bertinatto · 2019-11-13T18:11:53Z

Oh actually, can you update feature-gates.md too?
/lgtm cancel

Done! PTAL

bertinatto · 2019-11-13T18:16:41Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

 | `APIResponseCompression` | `false` | Alpha | 1.7 | |
 | `AppArmor` | `true` | Beta | 1.4 | |
-| `AttachVolumeLimit` | `true` | Alpha | 1.11 | 1.11 |
+| `AttachVolumeLimit` | `false` | Alpha | 1.11 | 1.11 |


This was set to true in Alpha, which I think is incorrect, right?

As a GA feature, this should move to the section Feature gates for graduated or deprecated features

I think we move the alpha and beta rows also to the graduated section below too

bertinatto · 2019-11-14T10:04:21Z

content/en/docs/concepts/storage/storage-limits.md

+It is recommended that CSI drivers allow for customization of volume limits
+as well. That way cluster administrators can distribute the limits of the
+same storage backends (e.g. iSCSI) accross different drivers, according to
+their individual needs.


@gnufied can you take a look at this?

I think this should be documented in - https://kubernetes-csi.github.io/docs/csi-node-object.html and not here because these are mostly user facing docs.

Makes sense. Removed

sftim

I spotted that the feature gate handling wasn't quite right

sftim · 2019-11-14T11:27:38Z

content/en/docs/concepts/storage/storage-limits.md


-Kubernetes 1.11 introduced support for dynamic volume limits based on Node type as an Alpha feature.
-In Kubernetes 1.12 this feature is graduating to Beta and will be enabled by default.
+Support for dynamic volume limits in Kubernetes 1.17 has been declared stable.


You can omit this line: the feature-state shortcode says the same thing.

sftim · 2019-11-14T11:28:48Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

 | `APIResponseCompression` | `false` | Alpha | 1.7 | |
 | `AppArmor` | `true` | Beta | 1.4 | |
-| `AttachVolumeLimit` | `true` | Alpha | 1.11 | 1.11 |
+| `AttachVolumeLimit` | `false` | Alpha | 1.11 | 1.11 |


As a GA feature, this should move to the section Feature gates for graduated or deprecated features

msau42 · 2019-11-16T02:08:02Z

content/en/docs/concepts/storage/storage-limits.md


 You can change these limits by setting the value of the
 `KUBE_MAX_PD_VOLS` environment variable, and then starting the scheduler.
+CSI drivers might have a diferent procedure, see their documentation


typo: different

msau42 · 2019-11-16T02:09:06Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

 | `APIResponseCompression` | `false` | Alpha | 1.7 | |
 | `AppArmor` | `true` | Beta | 1.4 | |
-| `AttachVolumeLimit` | `true` | Alpha | 1.11 | 1.11 |
+| `AttachVolumeLimit` | `false` | Alpha | 1.11 | 1.11 |


I think we move the alpha and beta rows also to the graduated section below too

bertinatto

Comments address, PTAL

bertinatto · 2019-11-18T10:52:52Z

content/en/docs/concepts/storage/storage-limits.md


 You can change these limits by setting the value of the
 `KUBE_MAX_PD_VOLS` environment variable, and then starting the scheduler.
+CSI drivers might have a diferent procedure, see their documentation


msau42 · 2019-11-18T15:09:25Z

/lgtm

daminisatya · 2019-11-19T08:11:48Z

@sftim lgtm from your side as well?

sftim · 2019-11-20T15:59:20Z

All fine by me. @bertinatto looks like this needs a rebase though?

bertinatto · 2019-11-21T08:31:02Z

@sftim @msau42, rebased! PTAL

daminisatya · 2019-11-21T09:17:45Z

/lgtm

daminisatya · 2019-11-21T09:18:05Z

/approve

k8s-ci-robot · 2019-11-21T09:18:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daminisatya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [daminisatya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* feat: graduate TaintNodesByCondition to GA (#17073) * Promote StartupProbe to beta (enabled by default). (#17164) * Watch bookmarks to GA (#17026) * feat: graduate ScheduleDaemonSetPods to GA (#17350) * Update Docker installation instructions (#17405) * Use exact version numbers for installing Docker in Ubuntu (#17428) * Move CSIMigration and CSIMigrationGCE to Beta in Kubernetes v1.17 (#17478) * Promote NodeLease feature to GA (#17189) * Update docs for csi topology ga (#17408) * Update RunAsUsername to beta (#17460) * doc:Update RunAsUsername to beta * doc: update samples - kubernetes.io/os is no longer beta * Updating based on review feedback * Promote Node-specific volume limits to GA (#17432) * Promote PodShareProcessNamespace to stable (#17192) * Promote PodShareProcessNamespace to stable * Add for_k8s_version to feature-state label Co-Authored-By: Tim Bannister <tim@scalefactory.com> * Readd version-check to shareProcessNamespace task * Update service load balancer finalizer doc for GA (#17438) * Update Topology Manager docs (#17451) * Added information on how device plugins can take advantage of Topology Manager * Updated the Topology Manager documentation to include additionalinformation and update some out of date sections * Fix broken Topology Manager link (#17746) Part of What's Next Device Plugin section * Update CRD defaulting docs for GA (#17450) * Add documentation for VolumeSnapshot Beta (#17233) * Updating EndpointSlice documentation for beta release in 1.17 (#17411) * (docs/dualstack): v1.17 updates (#17457) * Add placehold doc updates for dualstack in 1.17 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Add Downward API and /etc/hosts Pod IP validation Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove addressed known issue via k/k pr 85246 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Remove known issue and add flag as part of k/k 79993 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove follow up placeholders Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update verbiage Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Make IP addressing consistent throughout the task Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update to status.podIPs Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update content/en/docs/tasks/network/validate-dual-stack.md Use set instead of env Co-Authored-By: Khaled Henidak (Kal) <khnidk@outlook.com> * add topology.kubernetes.io/zone, topology.kubernetes.io/region and node.kubernetes.io/instance-type labels to docs (#17498) Signed-off-by: Andrew Sy Kim <kiman@vmware.com> * Service topology alpha documentation (#17459) * Update list of feature flags for in-tree plugins migrated to CSI (#17533) Signed-off-by: Deep Debroy <ddebroy@docker.com> * Update Node concept for TaintNodesByCondition going GA (#17577) * feat: graduate ResourceQuotaScopeSelectors to GA in 1.17 (#17554) * kubeadm: update the upgrade documentation for 1.17 (#17587) * doc: Simplify Windows deployments with RuntimeClass (#16697) * doc: Simplify Windows deployments with RuntimeClass * Updating on review feedback * doc: Adding windows-build label from enhancement 1301 * update doc for kubelet option --reserved-cpus (#17648) * feat: update TaintNodesByCondition in feature gates table (#17377) * Update docs for v1 resource quota configuration (#17547) * AdmissionConfiguration v1 (#17548) * Update WebhookAdmissionConfiguration examples (#17549) * Update AWS EBS Migration Feature state (#16126) * Add resource version section to api-concepts documentation (#16910) * Add Resource Version semantics section to api concepts * Clarify risks of going back in time, add details about compaction and watch cache sizes * Apply suggestions from liggitt Co-Authored-By: Jordan Liggitt <jordan@liggitt.net> * remove pesudocode, apply feedback * Fix typo * Clarify equality rules * Cleanup kubectl generators docs (#17609) * Write ReplicationController without a space * Drop mentioning unsupported cluster versions * Fix capitalization for “API group” * Tweak wording * Avoid using deprecated generator in example * add Antrea description in dev-1.17 (#17919) * Promote VolumeSubpathEnvExpansion to GA * Reference Documentation for the Kubernetes API for 1.17 (#18019) * Update feature-gates.md (#18033) * Reference Documentation for kubectl Commands for 1.17 (#18017) * Update for v1.17 (#18034) * Update config.toml(release-1.17) for 1.17 (#18031)

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 5, 2019

bertinatto mentioned this pull request Nov 5, 2019

Dynamic Maximum volume count kubernetes/enhancements#554

Closed

k8s-ci-robot requested review from jsafrane and msau42 November 5, 2019 11:29

k8s-ci-robot assigned gnufied and msau42 Nov 5, 2019

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2019

k8s-ci-robot added this to the 1.17 milestone Nov 5, 2019

sftim reviewed Nov 6, 2019

View reviewed changes

bertinatto force-pushed the volume_limits_ga branch from 4c5436f to a69bf78 Compare November 13, 2019 17:21

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019

bertinatto force-pushed the volume_limits_ga branch from a69bf78 to 0d8adc4 Compare November 13, 2019 18:11

bertinatto commented Nov 13, 2019

View reviewed changes

msau42 mentioned this pull request Nov 13, 2019

Volume limits can be shared among several CSI drivers kubernetes/kubernetes#83351

Closed

bertinatto force-pushed the volume_limits_ga branch 2 times, most recently from 71cfd8c to 1cf93fe Compare November 14, 2019 10:03

bertinatto commented Nov 14, 2019

View reviewed changes

sftim suggested changes Nov 14, 2019

View reviewed changes

bertinatto force-pushed the volume_limits_ga branch 2 times, most recently from b7ecbe9 to bc15987 Compare November 15, 2019 09:37

msau42 reviewed Nov 16, 2019

View reviewed changes

bertinatto force-pushed the volume_limits_ga branch from bc15987 to a1aa2cf Compare November 18, 2019 10:56

bertinatto commented Nov 18, 2019

View reviewed changes

bertinatto mentioned this pull request Nov 18, 2019

Add volume limits documentation kubernetes-csi/docs#226

Merged

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2019

Promote Node-specific volume limits to GA

1d204b4

bertinatto force-pushed the volume_limits_ga branch from a1aa2cf to 1d204b4 Compare November 21, 2019 08:29

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2019

k8s-ci-robot assigned daminisatya Nov 21, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019

k8s-ci-robot merged commit 03bf933 into kubernetes:dev-1.17 Nov 21, 2019

mrbobbytables pushed a commit that referenced this pull request Dec 6, 2019

Promote Node-specific volume limits to GA (#17432)

68ef194

Conversation

bertinatto commented Nov 5, 2019

Uh oh!

k8sio-netlify-preview-bot commented Nov 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bertinatto commented Nov 5, 2019

Uh oh!

makoscafee commented Nov 5, 2019

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

msau42 commented Nov 13, 2019

Uh oh!

msau42 commented Nov 13, 2019

Uh oh!

bertinatto commented Nov 13, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bertinatto left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msau42 commented Nov 18, 2019

Uh oh!

daminisatya commented Nov 19, 2019

Uh oh!

sftim commented Nov 20, 2019

Uh oh!

bertinatto commented Nov 21, 2019

Uh oh!

daminisatya commented Nov 21, 2019

Uh oh!

daminisatya commented Nov 21, 2019

Uh oh!

k8s-ci-robot commented Nov 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

k8sio-netlify-preview-bot commented Nov 5, 2019 •

edited

Loading