Remove a space previous a tooltip text#17194
Remove a space previous a tooltip text#17194k8s-ci-robot merged 2 commits intokubernetes:masterfrom bells17:remove-space-previous-tooltip-text
Conversation
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 3c74dc1 https://deploy-preview-17194--kubernetes-io-master-staging.netlify.com |
| {{- with (where $glossaryBundle.Translations ".Lang" . ) -}} | ||
| {{ $p := (index . 0) }}{{ $pages = $pages | lang.Merge ($p.Resources.ByType "page") }}{{ end }} | ||
| {{ end }} | ||
| {{- range site.Params.language_alternatives -}}{{- with (where $glossaryBundle.Translations ".Lang" . ) -}}{{ $p := (index . 0) }}{{ $pages = $pages | lang.Merge ($p.Resources.ByType "page") }}{{ end }}{{ end }} |
There was a problem hiding this comment.
hello @bells17. Thanks for looking into this issue.
Is it possible to fix this issue without taking away the indentation of the template code?
For example,
{{- and -}} should trim white space, https://golang.org/pkg/text/template#hdr-Text_and_spaces.
I have not tested where the template formatting is needed or if there is a bug.
{{- $pages = $pages | lang.Merge ($p.Resources.ByType "page") -}} or possibly another line.
There was a problem hiding this comment.
Hi @kbhawkey, thank you for your comment.
I improved this code, Please review it again.
|
/lgtm |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimangel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#15920 fixed unexpected line breaks for localized glossary tooltips.
But an unexpected space previous a tooltip text exists.
So I trimmed a space.