Fix unexpected line breaks for localized glossary tooltips#15920
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Aug 19, 2019
Merged
Conversation
c362319 to
b7dd48d
Compare
b7dd48d to
d20666d
Compare
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit c362319 https://deploy-preview-15920--kubernetes-io-master-staging.netlify.com |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit d20666d https://deploy-preview-15920--kubernetes-io-master-staging.netlify.com |
Contributor
|
/lgtm |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wahyuoi
pushed a commit
to wahyuoi/website
that referenced
this pull request
Sep 9, 2019
This was referenced Oct 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #15390, there is an issue with line breaks and glossary tooltips.
In English, the tooltip is displayed correctly :
However, in another language, say French, there is a line break issue :
This is kind of a workaround, but it seems that removing the line breaks in
layouts/partials/docs/glossary-terms.htmlfixes the issue...