Skip to content

Translating Organize Cluster Access to ID Localization#17035

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
wahyuoi:id/organizing-cluster-access
Oct 27, 2019
Merged

Translating Organize Cluster Access to ID Localization#17035
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
wahyuoi:id/organizing-cluster-access

Conversation

@wahyuoi
Copy link
Copy Markdown
Contributor

@wahyuoi wahyuoi commented Oct 19, 2019

Addresses #15341
/assign @irvifa

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 19, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 19, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 63316fe

https://deploy-preview-17035--kubernetes-io-master-staging.netlify.com

girikuncoro
girikuncoro requested changes Oct 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautifully translated, thanks for your contribution! 🎉 I just gave out some minor typos and wording suggestion, once these are addressed, we can get this PR merged

@wahyuoi @girikuncoro
Apply suggestions from code review
63316fe 
Co-Authored-By: Giri Kuncoro <girikuncoro@users.noreply.github.com>
@wahyuoi wahyuoi requested a review from girikuncoro October 21, 2019 11:58
@phanama
Copy link
Copy Markdown
Contributor

phanama commented Oct 25, 2019

/assign

@phanama
Copy link
Copy Markdown
Contributor

phanama commented Oct 25, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2019
@phanama
Copy link
Copy Markdown
Contributor

phanama commented Oct 25, 2019

/approve

@phanama
Copy link
Copy Markdown
Contributor

phanama commented Oct 25, 2019

Woops, can't do it yet haha.
Let's wait for @girikuncoro or @irvifa then @wahyuoi

@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented Oct 27, 2019

thank you for your contribution! 🎉 please help us translate other pages (or help us improve the process of translation) if you have time

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro, phanama

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7c87be5 into kubernetes:master Oct 27, 2019
@girikuncoro girikuncoro mentioned this pull request Nov 3, 2019
Closed
45 tasks
@wahyuoi wahyuoi mentioned this pull request Jan 10, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irvifa irvifa Awaiting requested review from irvifa

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

@phanama phanama

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wahyuoi @phanama @girikuncoro @k8s-ci-robot @irvifa