Skip to content

Cherry pick PR - Fix site build (#16531) #16645

Closed
aimeeu wants to merge 1 commit intokubernetes:release-1.16from
aimeeu:aimeeu-1.16-cherrypick-pr16531
Closed

Cherry pick PR - Fix site build (#16531) #16645
aimeeu wants to merge 1 commit intokubernetes:release-1.16from
aimeeu:aimeeu-1.16-cherrypick-pr16531

Conversation

@aimeeu
Copy link
Copy Markdown
Contributor

@aimeeu aimeeu commented Oct 1, 2019 •
edited
Loading

Cherry-picking PR #16531 from master to 1.16 so we can move to Hugo 0.57.2. See also PRs #16104 and #16151.

The *.profile file referenced do not need to be provided in a separate
file. Making them separate files is preventing hugo from correctly
building the site.

PRs in this "cherry pick" group: #16645, #16646, #16647, #16648, #16650

@tengqm @aimeeu
Fix site build (#16531)
1410545 
The `*.profile` file referenced do not need to be provided in a separate
file. Making them separate files is preventing hugo from correctly
building the site.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 1, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 1, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign gochist
You can assign the PR to them by writing /assign @gochist in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aimeeu aimeeu changed the title Fix site build (#16531) Cherry pick PR - Fix site build (#16531) Oct 1, 2019
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Oct 1, 2019

Hi @aimeeu. Is there a plan/need to port this fix to the last five versions?

Page preview:
https://deploy-preview-16645--k8s-v1-16.netlify.com/docs/tutorials/clusters/apparmor/

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2019
@aimeeu
Copy link
Copy Markdown
Contributor Author

aimeeu commented Oct 1, 2019

@kbhawkey yep - all the PRs have now been submitted: #16645, #16646, #16647, #16648, #16650. Updating other PRs now with this info.

This was referenced Oct 1, 2019
Merged
Merged
Merged
Merged
@aimeeu
Copy link
Copy Markdown
Contributor Author

aimeeu commented Oct 1, 2019

/assign @zacharysarah

@zacharysarah
Copy link
Copy Markdown
Contributor

zacharysarah commented Oct 1, 2019

@aimeeu @kbhawkey 👋 This PR isn't technically necessary:

  • This change is already in master
  • The current version is 1.16, which points to master
  • The docs release lead will merge master to release-1.16 during the 1.17 cycle

So we can safely close this one.

/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 1, 2019

@zacharysarah: Closed this PR.

Details

In response to this:

@aimeeu @kbhawkey 👋 This PR isn't technically necessary:

  • This change is already in master
  • The current version is 1.16, which points to master
  • The docs release lead will merge master to release-1.16 during the 1.17 cycle

So we can safely close this one.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aimeeu aimeeu deleted the aimeeu-1.16-cherrypick-pr16531 branch October 8, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@sftim sftim Awaiting requested review from sftim

Assignees

@kbhawkey kbhawkey

@zacharysarah zacharysarah

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aimeeu @k8s-ci-robot @kbhawkey @zacharysarah @tengqm