fix summary split in static-pod glossary item#15862
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom Aug 27, 2019
Merged
fix summary split in static-pod glossary item#15862k8s-ci-robot merged 2 commits intokubernetes:masterfrom
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
Conversation
Contributor
kbhawkey
commented
Aug 14, 2019
- Add summary split in content page; update content
- Update link in front matter
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit a40a122 https://deploy-preview-15862--kubernetes-io-master-staging.netlify.com |
Contributor
Author
|
/cc @sftim |
Contributor
Author
Contributor
|
/lgtm |
sftim
reviewed
Aug 15, 2019
|
|
||
| <!--more--> | ||
|
|
||
| A {{< glossary_tooltip text="pod" term_id="pod" >}} managed directly by the kubelet |
Contributor
There was a problem hiding this comment.
Does this glossary entry need a <!--more-->? The longer entry seems to say almost the same thing as the short version.
(Maybe a longer long version would work instead?)
Contributor
Author
There was a problem hiding this comment.
Hi @sftim. That is a nice idea. Here are some current problems:
- The current text for this entry is garbled. I can take some text from the static-pod content page and add to the more section to reduce the duplicated text.
- It would be great if the glossary entries did not have duplicate text; there are a number of entries where this is true.
- I believe all glossary entries use the hugo
moresummary divider. There appears to be a problem with the processing and rendering of the glossary entries, and the summary divider. I will log an issue to investigate. I would be in favor of a short term fix 😄 , though.
e800c2a to
a40a122
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wahyuoi
pushed a commit
to wahyuoi/website
that referenced
this pull request
Sep 9, 2019
* fix summary split in static-pod glossary item * update summary text, remove duplication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.