Skip to content

Recommend installing calico 3.8#15418

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ialidzhikov:enh/calico-3.8
Jul 21, 2019
Merged

Recommend installing calico 3.8#15418
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ialidzhikov:enh/calico-3.8

Conversation

@ialidzhikov
Copy link
Copy Markdown
Contributor

@ialidzhikov ialidzhikov commented Jul 14, 2019

Ref #15090.

@ialidzhikov
Recommend installing calico 3.8
2fbad17 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 14, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 14, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2fbad17

https://deploy-preview-15418--kubernetes-io-master-staging.netlify.com

@rekcah78
Copy link
Copy Markdown
Contributor

rekcah78 commented Jul 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2019
chenrui333
chenrui333 approved these changes Jul 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@chenrui333
Copy link
Copy Markdown
Member

chenrui333 commented Jul 16, 2019

/lgtm

@chenrui333
Copy link
Copy Markdown
Member

chenrui333 commented Jul 16, 2019

/approve

@inductor
Copy link
Copy Markdown
Member

inductor commented Jul 18, 2019

/assign @zacharysarah

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 21, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenrui333, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6e153db into kubernetes:master Jul 21, 2019
@ialidzhikov ialidzhikov deleted the enh/calico-3.8 branch July 21, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasayaAoyama MasayaAoyama Awaiting requested review from MasayaAoyama

1 more reviewer

@chenrui333 chenrui333 chenrui333 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chenrui333 chenrui333

@zacharysarah zacharysarah

@rekcah78 rekcah78

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ialidzhikov @rekcah78 @chenrui333 @inductor @tengqm @k8s-ci-robot @zacharysarah