Skip to content

kubeadm: recommend installing calico 3.8#15090

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
neolit123:calico-3.8-update
Jul 7, 2019
Merged

kubeadm: recommend installing calico 3.8#15090
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
neolit123:calico-3.8-update

Conversation

@neolit123
Copy link
Copy Markdown
Member

@neolit123 neolit123 commented Jun 24, 2019

This change is required since the 3.8 manifest moves to using
apps/v1 instead of extensions/v1beta1 for types like DaemonSet
and Deployment.

See PR 70672 of k/k.

/kind feature
/priority important-longterm
/sig cluster-lifecycle

@neolit123
kubeadm: recommend installing calico 3.8
6d2ddb8 
This change is required since the 3.8 manifest moves to using
apps/v1 instead of extensions/v1beta1 for types like DaemonSet
and Deployment.

See PR 70672 of k/k.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 24, 2019
yagonobre
yagonobre reviewed Jun 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2019
@caseydavenport
Copy link
Copy Markdown
Member

caseydavenport commented Jun 24, 2019

@neolit123 Calico v3.8.0 isn't released yet, please hold off on merging this until it is :)

@neolit123
Copy link
Copy Markdown
Member Author

neolit123 commented Jun 24, 2019

@caseydavenport what is the ETA on the release?
does this mean that the images that the manifest references are not out yet?

@caseydavenport
Copy link
Copy Markdown
Member

caseydavenport commented Jun 24, 2019

@neolit123 the images in the manifests exist, but are not stable.

The release itself has been pushed out a bit due to some issues found during QA. I can't give an exact ETA given we're still working through them.

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 24, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6d2ddb8

https://deploy-preview-15090--kubernetes-io-master-staging.netlify.com

@tengqm tengqm added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 25, 2019
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jun 25, 2019

Attached the "hold" label in case it gets merged by mistake.

@neolit123
Copy link
Copy Markdown
Member Author

neolit123 commented Jul 1, 2019

/hold cancel
calico 3.8 is out:
https://github.com/projectcalico/cni-plugin/releases/tag/v3.8.0

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2019
@neolit123
Copy link
Copy Markdown
Member Author

neolit123 commented Jul 4, 2019

/assign @tengqm

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 7, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7e3f178 into kubernetes:master Jul 7, 2019
This was referenced Jul 14, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yagonobre yagonobre yagonobre left review comments

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@tengqm tengqm

@yagonobre yagonobre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neolit123 @caseydavenport @tengqm @k8s-ci-robot @yagonobre