Write new task: Defining a Command and Arguments for a Container.#1526
Write new task: Defining a Command and Arguments for a Container.#1526pwittrock merged 4 commits intokubernetes:masterfrom steveperry-53:task-cmd-arg
Conversation
|
Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions. docs/tasks/configure-pod-container/define-command-argument-container.md, line 26 at r1 (raw file):
What does the args file override? The CMD specified in the container image? If I just specify args without command it will use the entrypoint specified the container image with the new args? docs/tasks/configure-pod-container/define-command-argument-container.md, line 57 at r1 (raw file):
Should we mention that args + commands can not be updated once the Pod is created? docs/tasks/configure-pod-container/define-command-argument-container.md, line 61 at r1 (raw file):
args can also be set using configmaps, secrets, or environment variables. Worth mentioning these in the whatsnext section. Comments from Reviewable |
|
Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions. docs/tasks/configure-pod-container/define-command-argument-container.md, line 26 at r1 (raw file):
|
|
Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions. docs/tasks/configure-pod-container/define-command-argument-container.md, line 75 at r2 (raw file):
This is easy to miss as it is different from how commands are specified in bash. Another thing I would mention is that if the user needs their command to be execute in a shell (e.g. they want to setup a pipe), then should execute it by passing it to sh like so:
Added note about parentheses. Comments from Reviewable |
|
Reviewed 3 of 4 files at r1, 1 of 1 files at r2. docs/tasks/configure-pod-container/define-command-argument-container.md, line 75 at r2 (raw file):
This will be necessary for tasks such as shell scripting and piping commands together. Added section on running the command in a shell. Comments from Reviewable |
|
love it |
|
Reviewed 1 of 1 files at r3. Comments from Reviewable |
* [IT] Create infrastructure-as-a-service.md Signed-off-by: annalisag-spark <83414097+annalisag-spark@users.noreply.github.com> * Update content/it/infrastructure-as-a-service.md Co-authored-by: Paolo Martinoli <81316809+ugho16@users.noreply.github.com> Signed-off-by: annalisag-spark <83414097+annalisag-spark@users.noreply.github.com> Signed-off-by: annalisag-spark <83414097+annalisag-spark@users.noreply.github.com> Co-authored-by: Paolo Martinoli <81316809+ugho16@users.noreply.github.com>
This change is