Skip to content

Change Windows line-endings to Unix#15195

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ialidzhikov:doc/unix-line-endings
Aug 27, 2019
Merged

Change Windows line-endings to Unix#15195
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ialidzhikov:doc/unix-line-endings

Conversation

@ialidzhikov
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 28, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Jun 28, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 606dd6f

https://deploy-preview-15195--kubernetes-io-master-staging.netlify.com

@ialidzhikov
Copy link
Copy Markdown
Contributor Author

/assign @steveperry-53

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2019
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov force-pushed the doc/unix-line-endings branch from 922b0ee to 606dd6f Compare August 4, 2019 13:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2019
@ialidzhikov
Copy link
Copy Markdown
Contributor Author

/assign @tengqm

@zacharysarah
Copy link
Copy Markdown
Contributor

@ialidzhikov 👋 Thanks for this PR. Out of curiosity, are you encountering any specific difficulties with the current line-endings?

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Aug 27, 2019

it is always good to be consistent.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 34c22e6 into kubernetes:master Aug 27, 2019
@ialidzhikov ialidzhikov deleted the doc/unix-line-endings branch August 27, 2019 15:37
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants