Skip to content

Fix CoreDNS version restriction for service ExternalName type.#15084

Merged
k8s-ci-robot merged 2 commits intokubernetes:release-1.14from
RainbowMango:pr_release_1.14-fix-en-zh-mismatch
Jun 28, 2019
Merged

Fix CoreDNS version restriction for service ExternalName type.#15084
k8s-ci-robot merged 2 commits intokubernetes:release-1.14from
RainbowMango:pr_release_1.14-fix-en-zh-mismatch

Conversation

@RainbowMango
Copy link
Copy Markdown
Member

before: This requires version 1.7 or higher of kube-dns.
after: You need CoreDNS version 1.7 or higher to use the ExternalName type.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2019
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 24, 2019
@RainbowMango
Copy link
Copy Markdown
Member Author

/assign @SataQiu

before: This requires version 1.7 or higher of `kube-dns`.
after: You need CoreDNS version 1.7 or higher to use the `ExternalName` type.
@RainbowMango RainbowMango force-pushed the pr_release_1.14-fix-en-zh-mismatch branch from 3a0e4ca to c321282 Compare June 28, 2019 06:40
Thanks.

Co-Authored-By: SataQiu <1527062125@qq.com>
@SataQiu
Copy link
Copy Markdown
Member

SataQiu commented Jun 28, 2019

thanks @RainbowMango
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 66e2573 into kubernetes:release-1.14 Jun 28, 2019
SataQiu added a commit to SataQiu/website that referenced this pull request Oct 9, 2019
…netes#15084)

* Fix CoreDNS version restriction for service ExternalName type.

before: This requires version 1.7 or higher of `kube-dns`.
after: You need CoreDNS version 1.7 or higher to use the `ExternalName` type.

* Update content/zh/docs/concepts/services-networking/service.md

Thanks.

Co-Authored-By: SataQiu <1527062125@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants