Skip to content

Update translation of file run-single-instance-stateful-application.md#14979

Merged
k8s-ci-robot merged 6 commits intokubernetes:release-1.14from
hyponet:update-translation
Jun 23, 2019
Merged

Update translation of file run-single-instance-stateful-application.md#14979
k8s-ci-robot merged 6 commits intokubernetes:release-1.14from
hyponet:update-translation

Conversation

@hyponet
Copy link
Copy Markdown
Contributor

@hyponet hyponet commented Jun 19, 2019

Hello,

I found the Chinese document very lagging on run-single-instance-stateful-application.md

https://kubernetes.io/zh/docs/tasks/run-application/run-single-instance-stateful-application/

And I updated the Chinese document.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 19, 2019
@hyponet hyponet closed this Jun 19, 2019
@hyponet hyponet deleted the update-translation branch June 19, 2019 10:58
@hyponet hyponet restored the update-translation branch June 19, 2019 11:02
@hyponet hyponet reopened this Jun 19, 2019
Copy link
Copy Markdown
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以麻烦你加上原文么?:smile:

还有就是英文和中文之间保持空格间距。也麻烦你把原来的翻译修改一下了。:+1:

Otherwise, lgtm!

@chenrui333
Copy link
Copy Markdown
Member

你可以参看一下最近merge 的PR。
https://github.com/kubernetes/website/pulls?utf8=%E2%9C%93&q=is%3Apr+label%3Alanguage%2Fzh+is%3Aclosed+zh-trans%3A

看看有没有什么问题。

@hyponet
Copy link
Copy Markdown
Contributor Author

hyponet commented Jun 21, 2019

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2019
@hyponet
Copy link
Copy Markdown
Contributor Author

hyponet commented Jun 21, 2019

@chenrui333
Hello,我对 PR 进行了修改,对原有的翻译也做了格式调整
感谢 review

FirstSeen LastSeen Count From SubobjectPath Type Reason Message
--------- -------- ----- ---- ------------- -------- ------ -------
33s 33s 1 {deployment-controller } Normal ScalingReplicaSet Scaled up replica set mysql-63082529 to 1
Conditions:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditions, OldReplicaSets, NewReplicaSet, on the same level Pod Template

Copy link
Copy Markdown
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also fix the yaml file format issue. lgtm!

@hyponet
Copy link
Copy Markdown
Contributor Author

hyponet commented Jun 22, 2019

@chenrui333 Thinks for your review, and I fixed the format.

@chenrui333
Copy link
Copy Markdown
Member

/lgtm
/approve

Thanks a lot

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenrui333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit db3a74b into kubernetes:release-1.14 Jun 23, 2019
SataQiu pushed a commit to SataQiu/website that referenced this pull request Oct 9, 2019
kubernetes#14979)

* update sample code in run-single-instance-stateful-application.md

* Update translation

* fix

* Update document format

* fix code style

* fix yaml format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants