zh-trans: add /content/zh/docs/tasks/administer-cluster/kms-provider.md#14937
zh-trans: add /content/zh/docs/tasks/administer-cluster/kms-provider.md#14937k8s-ci-robot merged 2 commits intokubernetes:release-1.14from yyqqing:zh-trans-kms-provider.md-1.14
Conversation
|
|
||
| * 需要 etcd v3 或更新版本 | ||
|
|
||
| {{< feature-state for_k8s_version="v1.12" state="beta" >}} |
There was a problem hiding this comment.
I think this should be updated to kubernetes v1.14
There was a problem hiding this comment.
release-1.14 里的英文版即是如此，仍是 v1.12。如果要改这里，可能需要同时向英文版里提交一个 pr。
|
|
||
| In response to procedure call Version, a compatible KMS plugin should return v1beta1 as VersionResponse.version --> | ||
|
|
||
| * kms 插件版本：`v1beta1` |
There was a problem hiding this comment.
Does this version might also need to be updated as well?
|
|
||
| All messages from KMS provider have the version field set to current version v1beta1 --> | ||
|
|
||
| * 消息版本：`v1beta1` |
There was a problem hiding this comment.
same here, is this version up to date with k8s v1.14?
|
|
||
| <!-- 2. Set the `--encryption-provider-config` flag on the kube-apiserver to point to the location of the configuration file. --> | ||
| 2. 设置 kube-apiserver 的 `--encryption-provider-config` 参数指向配置文件的位置。 | ||
| <!-- 3. Restart your API server. --> |
There was a problem hiding this comment.
I have bad experience before of adding comments in between the bullets (i.e. the number wont be reused as 1., 2., 3. in the sequential way), so if the preview does not good (i have not checked yet), i highly recommend to use the block comment out of the original english text so that the numbered items would be consistent.
There was a problem hiding this comment.
有序编号列表 在有 yaml 插入时会乱掉，甚至英文版也是如此。参见 https://kubernetes.io/docs/tasks/administer-cluster/kms-provider/。
我尝试过多种方法（包括将整个列表comment掉）都无法使有序列表正常，看起来似乎是 hugo 的问题。
PS: release-1.14 下我使用的是 hugo-0.54.0；hugo-0.55.6 编译失败
chenrui333
left a comment
There was a problem hiding this comment.
lgtm except very minor comments.
Co-Authored-By: chenrui <rui@meetup.com>
|
@chenrui333 |
|
@zhangqx2010 you dont need .md |
|
😆 My bad. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenrui333 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…md (kubernetes#14937) * zh-trans: add /content/zh/docs/tasks/administer-cluster/kms-provider.md * Update content/zh/docs/tasks/administer-cluster/kms-provider.md Co-Authored-By: chenrui <rui@meetup.com>
No description provided.