Skip to content

zh-trans: add /content/zh/docs/tasks/administer-cluster/namespaces-wa…#14931

Merged
k8s-ci-robot merged 5 commits intokubernetes:release-1.14from
yyqqing:zh-trans-namespaces-walkthrough.md-1.14
Jun 27, 2019
Merged

zh-trans: add /content/zh/docs/tasks/administer-cluster/namespaces-wa…#14931
k8s-ci-robot merged 5 commits intokubernetes:release-1.14from
yyqqing:zh-trans-namespaces-walkthrough.md-1.14

Conversation

@yyqqing
Copy link
Copy Markdown

@yyqqing yyqqing commented Jun 17, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 17, 2019
@yyqqing yyqqing closed this Jun 17, 2019
@yyqqing yyqqing reopened this Jun 17, 2019
@chenrui333
Copy link
Copy Markdown
Member

This is what exists in the previous release:
https://v1-12.docs.kubernetes.io/zh/docs/tasks/administer-cluster/namespaces-walkthrough/

<!-- Kubernetes {{< glossary_tooltip text="namespaces" term_id="namespace" >}}
help different projects, teams, or customers to share a Kubernetes cluster. -->

Kubernetes {{< glossary_tooltip text="namespaces" term_id="namespace" >}}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Kubernetes {{< glossary_tooltip text="namespaces" term_id="namespace" >}}
Kubernetes {{< glossary_tooltip text="namespace" term_id="namespace" >}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add translation (eg 命名空间) as well?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely good point 👍

Copy link
Copy Markdown
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@markthink
Copy link
Copy Markdown

@yyqqing 需要更新一下

@yyqqing
Copy link
Copy Markdown
Author

yyqqing commented Jun 24, 2019

@markthink 已更新。Thanks @sftim @chenrui333

@chenrui333
Copy link
Copy Markdown
Member

/lgtm
/approve

Thanks!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenrui333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit bb75088 into kubernetes:release-1.14 Jun 27, 2019
SataQiu pushed a commit to SataQiu/website that referenced this pull request Oct 9, 2019
kubernetes#14931)

* zh-trans: add /content/zh/docs/tasks/administer-cluster/namespaces-walkthrough.md

* 补充缺失文件

* Update content/zh/docs/tasks/administer-cluster/namespaces-walkthrough.md

Co-Authored-By: chenrui <rui@meetup.com>

* Update content/zh/docs/tasks/administer-cluster/namespaces-walkthrough.md

Co-Authored-By: chenrui <rui@meetup.com>

* update glossary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants